Skip to content

x/net/icmp: add support for PROBE (RFC 8335) #24440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikioh opened this issue Mar 18, 2018 · 5 comments
Closed

x/net/icmp: add support for PROBE (RFC 8335) #24440

mikioh opened this issue Mar 18, 2018 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mikioh
Copy link
Contributor

mikioh commented Mar 18, 2018 •
edited
Loading

RFC 8335 defines a new tool called PROBE, which uses new extended echo request message, new extended echo reply message and new interface identification extension, for collecting the status of a probed interface under circumstances that PING cannot be used. The icmp package of x/net repository has already implemented basic support for ICMP extensions. It's reasonable to support the new messages and extension for PROBE.
@mikioh mikioh added this to the Unreleased milestone Mar 18, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/63995 mentions this issue: icmp: use of subtests

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/63996 mentions this issue: internal/iana: add address family number constants

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/63997 mentions this issue: ipv4: update icmp parameters

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/63998 mentions this issue: ipv6: update icmp parameters

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/63999 mentions this issue: icmp: add support for extended echo request and echo reply messages

gopherbot pushed a commit to golang/net that referenced this issue Mar 19, 2018
@cixtor
icmp: use subtests
a4c73ec 
This change reorganizes the existing test cases for supporting new
messages and extension in upcoming CLs. It also renames ping_test.go
to diag_test.go for clarification.

Updates golang/go#24440.

Change-Id: I5753a2ddbe76423d996a37f583fcf32b65d380e9
Reviewed-on: https://go-review.googlesource.com/63995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Mar 19, 2018
@cixtor
internal/iana: add address family number constants
08b7f81 
Updates golang/go#24440.

Change-Id: Ic56bb1add57831d6c94f148d209417be5aa22cb2
Reviewed-on: https://go-review.googlesource.com/63996
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Mar 19, 2018
@cixtor
ipv4: update icmp parameters
344b2e3 
Updates golang/go#24440.

Change-Id: Icd7dbb9b6748ba8dd165eec1c0021650b7f4d97d
Reviewed-on: https://go-review.googlesource.com/63997
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Mar 19, 2018
@cixtor
ipv6: update icmp parameters
92b859f 
Updates golang/go#24440.

Change-Id: Idbe22ca853ea4771bb979782ef3bac8b03c59b87
Reviewed-on: https://go-review.googlesource.com/63998
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 19, 2018
@golang golang locked and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mikioh @andybons @gopherbot