Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: long test fails (TestAccidentalGitCheckout) #24436

Closed
ysmolski opened this issue Mar 17, 2018 · 19 comments
Closed

cmd/go: long test fails (TestAccidentalGitCheckout) #24436

ysmolski opened this issue Mar 17, 2018 · 19 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.11

Comments

@ysmolski
Copy link
Member

ysmolski commented Mar 17, 2018 •
edited
Loading

What version of Go are you using (go version)?

go version devel +2767c4e285 Fri Mar 16 21:01:28 2018 +0000 darwin/amd64

What operating system and processor architecture are you using (go env)?

go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/thorn/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/thorn/go"
GORACE=""
GOROOT="/Users/thorn/golang"
GOTMPDIR=""
GOTOOLDIR="/Users/thorn/golang/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/km/50gy6_q557v6_7vxbf9b29v00000gn/T/go-build428090470=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Running ./all.bash does not fail in any of tests: ALL TESTS PASSED.

When I run go test cmd/go I get these failed tests:

~/golang/src % go test cmd/go
--- FAIL: TestGoBuildDashAInDevBranch (0.30s)
	go_test.go:833: running testgo [install math]
	go_test.go:835: running testgo [build -v -a math]
	go_test.go:835: standard error:
	go_test.go:835: internal/cpu
		math

	go_test.go:836: testgo build -a math in dev branch DID NOT build runtime, but should have
	go_test.go:836: pattern runtime not found in standard error
--- FAIL: TestGoBuildDashAInReleaseBranch (0.47s)
	go_test.go:849: running testgo [install math net/http]
	go_test.go:851: running testgo [install -v -a math]
	go_test.go:851: standard error:
	go_test.go:851: internal/cpu
		math

	go_test.go:852: testgo build -a math in release branch DID NOT build runtime, but should have
	go_test.go:852: pattern runtime not found in standard error
--- FAIL: TestNewReleaseRebuildsStalePackagesInGOPATH (3.13s)
	go_test.go:892: running testgo [install -a p1]
	go_test.go:893: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
	go_test.go:893: standard output:
	go_test.go:893: false:

	go_test.go:902: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
	go_test.go:902: standard output:
	go_test.go:902: false:

	go_test.go:909: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
	go_test.go:909: standard output:
	go_test.go:909: false:

	go_test.go:909: ./testgo list claims p1 is NOT stale, incorrectly, after changing sys.go
--- FAIL: TestBuildIDContainsArchModeEnv (2.62s)
    --- FAIL: TestBuildIDContainsArchModeEnv/386 (1.23s)
    	go_test.go:4716: running testgo [install mycmd]
    	go_test.go:4718: running testgo [list -f {{.Stale}}:{{.StaleReason}} mycmd]
    	go_test.go:4718: standard output:
    	go_test.go:4718: true:stale dependency: runtime

    	go_test.go:4718: wrong reason for Stale=true: "stale dependency: runtime", want "stale dependency: runtime/internal/sys"
    --- FAIL: TestBuildIDContainsArchModeEnv/arm (1.39s)
    	go_test.go:4716: running testgo [install mycmd]
    	go_test.go:4718: running testgo [list -f {{.Stale}}:{{.StaleReason}} mycmd]
    	go_test.go:4718: standard output:
    	go_test.go:4718: true:stale dependency: runtime

    	go_test.go:4718: wrong reason for Stale=true: "stale dependency: runtime", want "stale dependency: runtime/internal/sys"
--- FAIL: TestAccidentalGitCheckout (0.85s)
	go_test.go:1465: running testgo [get -u vcs-test.golang.org/go/test1-svn-git]
	go_test.go:1465: standard error:
	go_test.go:1465: package vcs-test.golang.org/go/test1-svn-git: unrecognized import path "vcs-test.golang.org/go/test1-svn-git" (https fetch: Get https://vcs-test.golang.org/go/test1-svn-git?go-get=1: x509: certificate has expired or is not yet valid)

	go_test.go:1465: testgo failed as expected: exit status 1
	go_test.go:1466: get did not fail for right reason
	go_test.go:1466: pattern src[\\/]vcs-test.* uses git, but parent .*src[\\/]vcs-test.* uses svn not found in standard error
--- FAIL: TestMoveHG (0.37s)
	go_test.go:1272: running testgo [get -d vcs-test.golang.org/go/custom-hg-hello]
	go_test.go:1272: standard error:
	go_test.go:1272: package vcs-test.golang.org/go/custom-hg-hello: unrecognized import path "vcs-test.golang.org/go/custom-hg-hello" (https fetch: Get https://vcs-test.golang.org/go/custom-hg-hello?go-get=1: x509: certificate has expired or is not yet valid)

	go_test.go:1272: go [get -d vcs-test.golang.org/go/custom-hg-hello] failed unexpectedly: exit status 1
FAIL
FAIL	cmd/go	268.072s

Also it takes 268 seconds compared to all.bash: ok cmd/go 59.136s

What did you expect to see?

No errors.
@ALTree
Copy link
Member

ALTree commented Mar 17, 2018

To add another data point, I can reproduce this on tip on linux/amd64.

Also it takes 268 seconds compared to all.bash: ok cmd/go 59.136s

This is expected because all.bash runs the tests using the -short flag. Time-consuming tests that are skipped by all.bash get executed when you manually run go test.

@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 17, 2018
@ALTree ALTree added this to the Go1.11 milestone Mar 17, 2018
@alexd765
Copy link
Contributor

This has been failing for quite some time.

Git bisect points to 76015

@ysmolski
Copy link
Member Author

ping @rsc

@alexd765 alexd765 mentioned this issue Mar 20, 2018
Closed
@ysmolski
Copy link
Member Author

ysmolski commented Mar 29, 2018 •
edited
Loading

Doing research regarding TestGoBuildDashA* tests. CL 76015 removed dependency on runtime package for non-main packages, so that go build -a math does not rebuild runtime anymore. Also TestGoBuildDashAInReleaseBranch tested some hack about preventing rebuilding system packages in release branch. I have not found any need to test that behaviour anymore.

Also I could not find environment variable TESTGO_IS_GO_RELEASE anywhere else except in those two tests. So I assume that it can be removed completely along with TestGoBuildDashAInReleaseBranch test b/c there is no need for testing release branch anymore and we can have just a general TestGoBuildDashA test.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/103416 mentions this issue: cmd/go: fix build -a tests

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/103675 mentions this issue: cmd/go: fix the rebuilding stale packages test

gopherbot pushed a commit that referenced this issue May 9, 2018
@ianlancetaylor
cmd/go: fix the rebuilding stale packages test
3e29712 
Non-main packages do not depend on the "runtime" package,
but main packages still do. Use a main package in the test.

This change passes the -i flag to the install command
to allow installation of updated dependencies,
and removes "install std" as unnecessary.

https://golang.org/cl/107957 is relevant to fixed test.

Updates #24436

Change-Id: If1845f37581a16ad77e72e50be21010e198bc7c5
Reviewed-on: https://go-review.googlesource.com/103675
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ysmolski
Copy link
Member Author

ysmolski commented May 11, 2018 •
edited
Loading

The most recent run is below. Two first fails should be handled by the CL 103416.
Test TestBuildIDContainsArchModeEnv is not tackled by any CL so far.

% go version
go version devel +4122319e5a Fri May 11 16:47:28 2018 +0000 darwin/amd64
% go test cmd/go
--- FAIL: TestGoBuildDashAInDevBranch (0.33s)
	go_test.go:841: running testgo [install math]
	go_test.go:843: running testgo [build -v -a math]
	go_test.go:843: standard error:
	go_test.go:843: internal/cpu
		math

	go_test.go:844: testgo build -a math in dev branch DID NOT build runtime, but should have
	go_test.go:844: pattern runtime not found in standard error
--- FAIL: TestGoBuildDashAInReleaseBranch (0.45s)
	go_test.go:857: running testgo [install math net/http]
	go_test.go:859: running testgo [install -v -a math]
	go_test.go:859: standard error:
	go_test.go:859: internal/cpu
		math

	go_test.go:860: testgo build -a math in release branch DID NOT build runtime, but should have
	go_test.go:860: pattern runtime not found in standard error
--- FAIL: TestBuildIDContainsArchModeEnv (2.69s)
    --- FAIL: TestBuildIDContainsArchModeEnv/386 (1.31s)
    	go_test.go:4852: running testgo [install mycmd]
    	go_test.go:4854: running testgo [list -f {{.Stale}}:{{.StaleReason}} mycmd]
    	go_test.go:4854: standard output:
    	go_test.go:4854: true:stale dependency: internal/cpu

    	go_test.go:4854: wrong reason for Stale=true: "stale dependency: internal/cpu", want "stale dependency: runtime/internal/sys"
    --- FAIL: TestBuildIDContainsArchModeEnv/arm (1.38s)
    	go_test.go:4852: running testgo [install mycmd]
    	go_test.go:4854: running testgo [list -f {{.Stale}}:{{.StaleReason}} mycmd]
    	go_test.go:4854: standard output:
    	go_test.go:4854: true:stale dependency: internal/cpu

    	go_test.go:4854: wrong reason for Stale=true: "stale dependency: internal/cpu", want "stale dependency: runtime/internal/sys"
FAIL
FAIL	cmd/go	300.550s

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/112975 mentions this issue: cmd/go: fix TestBuildIDContainsArchModeEnv

gopherbot pushed a commit that referenced this issue May 14, 2018
@ianlancetaylor
cmd/go: fix TestBuildIDContainsArchModeEnv
c06f027 
Changing GOARCH, GOARM, GO386 leads to a stale dependency.

Updates #24436.

Change-Id: I5b5b3fca6401be50fa81fb040bc56356de7555de
Reviewed-on: https://go-review.googlesource.com/112975
Run-TryBot: Yury Smolsky <yury@smolsky.by>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@ysmolski ysmolski mentioned this issue May 14, 2018
Closed
@ysmolski
Copy link
Member Author

The only remaining fix: https://golang.org/cl/103416

ping @ianlancetaylor @rsc

@ysmolski
Copy link
Member Author

TestNewReleaseRebuildsStalePackagesInGOPATH still fails on linux-amd64-longtest:
https://build.golang.org/log/412d4a44a2469e2919309a2ec9b3765d3a1de7a7

I am unable to reproduce this locally on darwin. Any ideas how can I do it?

--- FAIL: TestNewReleaseRebuildsStalePackagesInGOPATH (4.60s)
    go_test.go:902: running testgo [install -i p1]
    go_test.go:903: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:903: standard output:
    go_test.go:903: false:
        
    go_test.go:912: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:912: standard output:
    go_test.go:912: false:
        
    go_test.go:919: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:919: standard output:
    go_test.go:919: true:stale dependency: runtime/internal/sys
        
    go_test.go:921: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:921: standard output:
    go_test.go:921: false:
        
    go_test.go:923: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:923: standard output:
    go_test.go:923: true:stale dependency: runtime/internal/sys
        
    go_test.go:924: running testgo [install -i p1]
    go_test.go:925: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:925: standard output:
    go_test.go:925: false:
        
    go_test.go:929: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:929: standard output:
    go_test.go:929: false:
        
    go_test.go:929: ./testgo list claims p1 is NOT stale, incorrectly, after restoring sys.go

@ysmolski ysmolski changed the title cmd/go: testing this specific package is failing cmd/go: long test fails Jul 13, 2018
@ysmolski
Copy link
Member Author

Long test from tip passes on my darwin (El Capitan). It still fails on linux builder:

--- FAIL: TestNewReleaseRebuildsStalePackagesInGOPATH (4.65s)
    go_test.go:906: running testgo [install -i p1]
    go_test.go:907: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:907: standard output:
    go_test.go:907: false:
        
    go_test.go:916: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:916: standard output:
    go_test.go:916: false:
        
    go_test.go:923: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:923: standard output:
    go_test.go:923: true:stale dependency: runtime/internal/sys
        
    go_test.go:925: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:925: standard output:
    go_test.go:925: false:
        
    go_test.go:927: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:927: standard output:
    go_test.go:927: true:stale dependency: runtime/internal/sys
        
    go_test.go:928: running testgo [install -i p1]
    go_test.go:929: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:929: standard output:
    go_test.go:929: false:
        
    go_test.go:933: running testgo [list -f {{.Stale}}:{{.StaleReason}} p1]
    go_test.go:933: standard output:
    go_test.go:933: false:
        
    go_test.go:933: ./testgo list claims p1 is NOT stale, incorrectly, after restoring sys.go
go test proxy starting
go test proxy running at GOPROXY=http://127.0.0.1:38065/mod
--- FAIL: TestAccidentalGitCheckout (6.01s)
    go_test.go:1527: running testgo [get -u vcs-test.golang.org/go/test1-svn-git]
    go_test.go:1527: standard error:
    go_test.go:1527: package vcs-test.golang.org/go/test1-svn-git/git-README-only/pkg: directory "/tmp/gotest830344226/src/vcs-test.golang.org/go/test1-svn-git/git-README-only" uses git, but parent "/tmp/gotest830344226/src/vcs-test.golang.org/go/test1-svn-git" uses svn
        
    go_test.go:1527: testgo failed as expected: exit status 1
    go_test.go:1530: running testgo [get -u vcs-test.golang.org/go/test2-svn-git/test2main]
    go_test.go:1530: standard error:
    go_test.go:1530: package vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg: cannot find package "vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg" in any of:
        	/workdir/go/src/vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg (from $GOROOT)
        	/tmp/gotest830344226/src/vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg (from $GOPATH)
        
    go_test.go:1530: testgo failed as expected: exit status 1
    go_test.go:1531: get did not fail for right reason
    go_test.go:1531: pattern src[\\/]vcs-test.* uses git, but parent .*src[\\/]vcs-test.* uses svn not found in standard error
FAIL
FAIL	cmd/go	244.229s
2018/07/13 04:12:40 Failed: exit status 1

@mvdan
Copy link
Member

mvdan commented Jul 13, 2018

I can reproduce both failures on my Linux laptop - will try to investigate.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/123737 mentions this issue: cmd/go: fix stale packages long test

@mvdan
Copy link
Member

mvdan commented Jul 13, 2018

I think I wrapped my mind around what was happening in the first failure - sent the CL above.

I'm giving up on the second one for now, as I don't know enough about how go get -u works when mixing svn and git. Although it seems to me like the vcs-test package has been broken, as now using go get -u tries to get the non-existing test2pkg/pkg subpackage.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/123815 mentions this issue: cmd/go: make TestNewReleaseRebuildsStalePackagesInGOPATH pass again

gopherbot pushed a commit that referenced this issue Jul 16, 2018
@ianlancetaylor
cmd/go: make TestNewReleaseRebuildsStalePackagesInGOPATH pass again
b323709 
The test TestNewReleaseRebuildsStalePackagesInGOPATH is not run in
short mode, so people tend to not notice when it fails. It was failing
due to the build cache. Make it pass again by 1) changing it to modify
the package in a way visible to the compiler, so that the change is
not hidden by caching; 2) accepting "not installed but available in
build cache" as always being a valid reason for a stale package, as go
list does not try to figure out an underlying reason for why a package
is stale when it finds it in the build cache but not installed.

Updates #24436

Change-Id: Iaeaa298f153451ec913a653dd4e6da79a33055bb
Reviewed-on: https://go-review.googlesource.com/123815
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@bradfitz bradfitz changed the title cmd/go: long test fails cmd/go: long test fails (TestAccidentalGitCheckout) Jul 19, 2018
@bradfitz
Copy link
Contributor

/cc @bcmills, @rsc to fix TestAccidentalGitCheckout

@ysmolski
Copy link
Member Author

I have found something about TestAccidentalGitCheckout. It fetches repo which has partly-capitalized directory test2PKG inside, while the main package imports it using test2PKG and test2pkg. Apparrently, Linux cannot find the lowercase variant, while it works on MacOS.

% pwd
/Users/thorn/go/src/vcs-test.golang.org/go/test2-svn-git
% tree
.
├── test2PKG
│   ├── p1
│   │   └── p1.go
│   └── pkg
│       └── pkg.go
└── test2main
    └── main.go

% cat test2main/main.go
package main

import _ "vcs-test.golang.org/go/test2-svn-git/test2PKG/p1"
import _ "vcs-test.golang.org/go/test2-svn-git/test2pkg/pkg"

func main() {}

@ysmolski
Copy link
Member Author

I don't see how to modify those files according to https://github.com/golang/build/blob/master/vcs-test/README.md

Also this bug was already filed: #22983

@bcmills
Copy link
Contributor

bcmills commented Aug 2, 2018

Closing as a dup of #22983. Since that was reported on 1.9.2, it doesn't need to be a release-blocker.

@bcmills bcmills closed this as completed Aug 2, 2018
@golang golang locked and limited conversation to collaborators Aug 2, 2019
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
9 participants
@bradfitz @rsc @ysmolski @ianlancetaylor @mvdan @ALTree @bcmills @gopherbot @alexd765