Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc/static: Missing x/time subrepo. #24430

Closed
dmitshur opened this issue Mar 16, 2018 · 2 comments
Closed

x/tools/godoc/static: Missing x/time subrepo. #24430

dmitshur opened this issue Mar 16, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 16, 2018 •
edited

golang.org/x/time appears to be a real, albeit small, subrepo. Its source is https://go.googlesource.com/time and it's mirrored to https://github.com/golang/time.

package.html does not include it in the list of all sub-repositories.
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2018
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 16, 2018
@dmitshur dmitshur self-assigned this Mar 16, 2018
@gopherbot
Copy link

Change https://golang.org/cl/101241 mentions this issue: godoc/static: add x/time subrepo

@dmitshur dmitshur removed their assignment Mar 16, 2018
@dmitshur dmitshur mentioned this issue Mar 16, 2018
Closed
@dmitshur
Copy link
Contributor Author

dmitshur commented Mar 16, 2018 •
edited

I sent a trivial CL that just manually adds a new entry. That's how it was done before, i.e., see #9081 and golang/tools@06e42bd.

I noticed that that are even more subrepos missing. That's outside of scope of this issue and will probably involve some discussion and decisions (should all the subrepos be displayed, or should some be hidden? should codereview entry pointing at code.google.com be removed? etc.). Filed a higher level issue #24432 to track that.

@golang golang locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot