Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: test broken for 1.10, 1.9 due to version issues #24421

Closed
griesemer opened this issue Mar 16, 2018 · 8 comments
Closed

x/tools/cmd/guru: test broken for 1.10, 1.9 due to version issues #24421

griesemer opened this issue Mar 16, 2018 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@griesemer
Copy link
Contributor

Just a reminder issue to fix this better.

See https://go-review.googlesource.com/c/tools/+/101015 for details.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 16, 2018
@griesemer griesemer added this to the Go1.11 milestone Mar 16, 2018
@griesemer griesemer self-assigned this Mar 16, 2018
@bradfitz bradfitz mentioned this issue Apr 11, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/106435 mentions this issue: cmd/guru: skip broken test for old Go versions for now

gopherbot pushed a commit to golang/tools that referenced this issue Apr 11, 2018
@bradfitz
cmd/guru: skip broken test for old Go versions for now
368a7e1 
Updates golang/go#24421

Change-Id: Iedcb629135802f78e8f149b377f34e49c8019fe9
Reviewed-on: https://go-review.googlesource.com/106435
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/112375 mentions this issue: cmd/guru: skip broken test for old Go versions for now

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@griesemer
Copy link
Contributor Author

Not sure if there's still something to do here. With 1.12 we will only support 1.11 and 1.10. Leaving to @alandonovan to decide.

@griesemer griesemer assigned alandonovan and unassigned griesemer Sep 18, 2018
@odeke-em
Copy link
Member

odeke-em commented Feb 4, 2019

Kindly paging you @alandonovan to follow-up on @griesemer's request in #24421 (comment)

@alandonovan
Copy link
Contributor

@stamblerre

@stamblerre stamblerre self-assigned this Feb 4, 2019
@stamblerre
Copy link
Contributor

I think the only thing left is to delete the Go 1.9-specific tests - they were added when we still needed to support 1.8, but now all these tests can be recombined.

@odeke-em
Copy link
Member

odeke-em commented Feb 4, 2019

Great, thank you @stamblerre and @alandonovan for following up with the game plan! Sure, we'll leave this issue in for Go1.12.

@gopherbot
Copy link

Change https://golang.org/cl/161000 mentions this issue: cmd/guru: remove Go 1.9 handling, since we no longer support 1.8

@golang golang locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@odeke-em @stamblerre @alandonovan @griesemer @gopherbot