Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crytpo/x509: MarshalPKCS8PrivateKey doc erraneously says ecdsa.PublicKey instead of ecdsa.PrivateKey #24413

Closed
golangdaddy opened this issue Mar 15, 2018 · 2 comments
Closed

crytpo/x509: MarshalPKCS8PrivateKey doc erraneously says ecdsa.PublicKey instead of ecdsa.PrivateKey #24413

golangdaddy opened this issue Mar 15, 2018 · 2 comments
Labels
Documentation FrozenDueToAge

Comments

@golangdaddy
Copy link

Documentation error for x509.MarshalPKCS8PrivateKey...

Docs say this will marshal ecdsa.PublicKey but the author obviously meant ecdsa.PrivateKey.

ecdsa.PublicKey does not marshal:

x509: unknown key type while marshalling PKCS#8: *ecdsa.PublicKey
@gopherbot
Copy link

Change https://golang.org/cl/100839 mentions this issue: crypto/x509: clarify accepted keys for MarshalPKCS8PrivateKey

@adamdecaf
Copy link
Contributor

Thanks for catching that!

@odeke-em odeke-em changed the title x509 documentation error crytpo/x509: MarshalPKCS8PrivateKey doc erraneously says ecdsa.PublicKey instead of ecdsa.PrivateKey Mar 15, 2018
@golang golang locked and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adamdecaf @FiloSottile @golangdaddy @gopherbot