Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: vendored internal/driver has flaky tests #24405

Closed
mvdan opened this issue Mar 15, 2018 · 2 comments
Closed

cmd/pprof: vendored internal/driver has flaky tests #24405

mvdan opened this issue Mar 15, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@mvdan
Copy link
Member

mvdan commented Mar 15, 2018

This issue was already reported upstream weeks ago: google/pprof#328

I am filing this since it's happened a few times that we know of, so this one should help us track the fix better and help others who stumble upon the same failure.

For search purposes, the test in question is TestHttpInsecure.

Assigning to self, to update the vendored packages once the upstream bug is fixed.
@mvdan mvdan added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 15, 2018
@mvdan mvdan added this to the Go1.11 milestone Mar 15, 2018
@mvdan mvdan self-assigned this Mar 15, 2018
@mvdan
Copy link
Member Author

mvdan commented Mar 15, 2018

Another potential question is why we need to run the vendored library tests, or why we vendor their test files at all. But I assume we do want that for one reason or another, such as being extra sure that all platforms are supported.

@mvdan mvdan mentioned this issue Apr 3, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/105275 mentions this issue: cmd/vendor/.../pprof: update to 0f7d9ba1

@golang golang locked and limited conversation to collaborators Apr 6, 2019
@rsc rsc unassigned mvdan Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@mvdan @gopherbot