Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: Gobot shouldn't be added as a CC/Reviewer #24382

Open
mvdan opened this issue Mar 13, 2018 · 5 comments
Open

x/build/cmd/gerritbot: Gobot shouldn't be added as a CC/Reviewer #24382

mvdan opened this issue Mar 13, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Mar 13, 2018

Gobot is added as a CC when it says "Trybots beginning", and as a Reviewer when it posts Trybot-Result+1 or Trybot-Result-1. For example, see: https://go-review.googlesource.com/c/go/+/100475

I realise that this is how Gerrit is supposed to work for humans - a user should be subscribed to updates if they comment, and added as a reviewer if they touch one of the flags/labels. However, I think this is noisy for bots. Is there a way to keep it from happening?
@gopherbot gopherbot added this to the Unreleased milestone Mar 13, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 13, 2018
@andybons
Copy link
Member

Are you referring to the fact that it’s even there in the list of CC/Reviewers as being noisy?

@mvdan
Copy link
Member Author

mvdan commented Mar 15, 2018

Yes - and also how being added to those shows up in the CL comments.

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 15, 2018
@andybons andybons self-assigned this Mar 15, 2018
@andybons
Copy link
Member

andybons commented Mar 29, 2018 •
edited

This fix is needed but it will have to start in Gerrit. This is just the way Gerrit currently works, with no configuration options (that I'm aware of) to suppress the behavior.

@andybons andybons removed their assignment Mar 29, 2018
@mvdan
Copy link
Member Author

mvdan commented Mar 29, 2018

I imagined as much - but I assume that even if they added this feature, gerritbot would need to be modified accordingly.

I've created an issue upstream - feel free to add to it if I have missed anything, or misunderstood how Gobot works: https://bugs.chromium.org/p/gerrit/issues/detail?id=8658

@andybons
Copy link
Member

Thank you.

@mvdan mvdan mentioned this issue Nov 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @mvdan @gopherbot