Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: remove g.gcscanvalid #24363

Closed
josharian opened this issue Mar 12, 2018 · 3 comments
Closed

runtime: remove g.gcscanvalid #24363

josharian opened this issue Mar 12, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@josharian
Copy link
Contributor

@aclements commented in CL 99078:

Yeah, we should probably remove gcscanvalid now that we don't rescan stacks.

This will also shrink the size of struct g a little bit.
@josharian josharian added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 12, 2018
@josharian josharian added this to the Go1.11 milestone Mar 12, 2018
@josharian josharian changed the title runtime: remove gcscanvalid runtime: remove g.gcscanvalid Mar 12, 2018
@mvdan
Copy link
Member

mvdan commented Mar 12, 2018

I wonder if we should mark these TODO issues on the easy side as help-wanted, to attract more first-time contributors.

@josharian
Copy link
Contributor Author

I don’t know whether this is easy. :) But if so, definitely.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jul 10, 2018
@aclements aclements modified the milestones: Go1.12, Go1.13 Jan 8, 2019
@aclements aclements modified the milestones: Go1.13, Go1.14 May 28, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/201139 mentions this issue: runtime: remove g.gcscanvalid

@golang golang locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@josharian @rsc @aclements @ianlancetaylor @mvdan @gopherbot