net: IPv4 String method is not efficient and could be improved #24306
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Performance
Milestone
Comments
|
I have a better implementation. https://play.golang.org/p/-LG8jshs4ak Also did BenchMark test: Before fix: ../bin/go test -bench=BenchmarkIPString -run=^ip ./net/ After fix: pkg: net This is optimization namely for IPv4 and it gives ~75% improvement. |
vkuzmin-uber
changed the title
vkuzmin-uber
changed the title
|
Change https://golang.org/cl/99395 mentions this issue: |
andybons
added
the
NeedsFix
odeke-em
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?1.9, 1.10
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env)?darwin_amd64, linux_amd64
What did you do?
Converted ip.net to human readable string, namely called net.IP.String(). On a scale 1000 IPs, pprof reported it as a one of the most expensive operation.
String representation is often used as a key in map containers, for stringset but pprof will show again that this is a most expensive operation and you will need to provide some custom converter from net.IP to key as a [4]byte or [16]byte.
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
A better, more efficient implementation
What did you see instead?
A very expensive operation and custom is much more efficient.
The text was updated successfully, but these errors were encountered: