Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestVetWithOnlyCgoFiles failing on Plan 9 #24304

Closed
0intro opened this issue Mar 7, 2018 · 3 comments
Closed

cmd/go: TestVetWithOnlyCgoFiles failing on Plan 9 #24304

0intro opened this issue Mar 7, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Milestone
Go1.11

Comments

@0intro
Copy link
Member

0intro commented Mar 7, 2018

CL 99175 added TestVetWithOnlyCgoFiles. However, this test is failing on Plan 9.

--- FAIL: TestVetWithOnlyCgoFiles (0.12s)
	go_test.go:3243: running testgo [vet p]
	go_test.go:3243: standard error:
	go_test.go:3243: can't load package: package p: build constraints exclude all Go files in /tmp/gotest874832146/src/p
		
	go_test.go:3243: go [vet p] failed unexpectedly: exit status: 'testgo 2781: 1'
FAIL
FAIL	cmd/go	140.465s

See https://build.golang.org/log/4f68771333f1332d45b1faaebb05892188b01c85
@0intro 0intro added the OS-Plan9 label Mar 7, 2018
@0intro 0intro added this to the Go1.11 milestone Mar 7, 2018
@0intro 0intro self-assigned this Mar 7, 2018
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 7, 2018
@0intro
Copy link
Member Author

0intro commented Mar 7, 2018 •
edited

More generally, this test should be disabled on every platform where cgo is disabled.

@gopherbot
Copy link

Change https://golang.org/cl/99275 mentions this issue: cmd/go: skip TestVetWithOnlyCgoFiles when cgo is disabled

@gopherbot
Copy link

Change https://golang.org/cl/103223 mentions this issue: [release-branch.go1.10] cmd/go: skip TestVetWithOnlyCgoFiles when cgo is disabled

gopherbot pushed a commit that referenced this issue Mar 29, 2018
@0intro @andybons
[release-branch.go1.10] cmd/go: skip TestVetWithOnlyCgoFiles when cgo…
8e1f12f 
… is disabled

CL 99175 added TestVetWithOnlyCgoFiles. However, this
test is failing on platforms where cgo is disabled,
because no file can be built.

This change fixes TestVetWithOnlyCgoFiles by skipping
this test when cgo is disabled.

Fixes #24304.

Change-Id: Ibb38fcd3e0ed1a791782145d3f2866f12117c6fe
Reviewed-on: https://go-review.googlesource.com/99275
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit b133503)
Reviewed-on: https://go-review.googlesource.com/103223
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Mar 29, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@andybons @0intro @gopherbot