Skip to content

x/text/language/display: Inconsistent cases of language names #24236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hajimehoshi opened this issue Mar 4, 2018 · 4 comments
Closed

x/text/language/display: Inconsistent cases of language names #24236

hajimehoshi opened this issue Mar 4, 2018 · 4 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@hajimehoshi
Copy link
Member

hajimehoshi commented Mar 4, 2018

Please answer these questions before submitting your issue. Thanks!

Does this issue reproduce with the latest release?

Yes

What did you do?

Run https://play.golang.org/p/SfrZkuOzAgo

What did you expect to see?

English
Français
Deutsch
Español
Español de España
Español latinoamericano // or, Español Latinoamericano?

What did you see instead?

English
français
Deutsch
español
español de España
español latinoamericano

I'm not confident each language's rule, but should language names start with upper cases?

There might be other similar languages.

@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2018
@namusyaka namusyaka added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 4, 2018
@namusyaka
Copy link
Member

/cc @mpvl

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/100155 mentions this issue: ipv4, ipv6, icmp, internal/socket: fix build on netbsd/arm

@spf13
Copy link
Contributor

spf13 commented Mar 26, 2018

ping @mpvl for decision

@rsc
Copy link
Contributor

rsc commented Mar 27, 2018

Quoting the language matching blog post:

In the second column, note the differences in capitalization, reflecting the rules of the respective language.

So this is working as it should.

@rsc rsc closed this as completed Mar 27, 2018
@golang golang locked and limited conversation to collaborators Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

5 participants