cmd/link: Windows -H windowsgui stopped working in Go 1.10? #24232

devorel · 2018-03-03T23:49:00Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)? 1.10

Does this issue reproduce with the latest release? yes ,just the last

What operating system and processor architecture are you using (`go env`)? windows 10 ,intel i7

What did you do?

go build -ldflags "-H windowsgui" -v -o %gopath%/bin/test.exe my\proj\test.io

if i compile my program with version 1.9 , it's work good!
but if i compile my program in the last version 1.10 , i get black window console

What did you expect to see?

my window program without window console

What did you see instead?

my window program with window console

The text was updated successfully, but these errors were encountered:

alexbrainman · 2018-03-04T02:53:14Z

@devorel I cannot reproduce this. I did this:

c:\>go version
go version go1.10 windows/amd64

c:\>go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui

c:\>

and then I double clicked on %TMP%\a.exe. I don't see any window console.

What did I do wrong?

Thank you.

Alex

devorel · 2018-03-04T04:34:05Z

You are use with shrot process. If u use with server in the Background you need hold your process . I dont need window console for that.. בתאריך 4 במרץ 2018 04:54,‏ "Alex Brainman" <notifications@github.com> כתב: @devorel <https://github.com/devorel> I cannot reproduce this. I did this: c:\>go version go version go1.10 windows/amd64 c:\>go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui c:\> and then I double clicked on %TMP%\a.exe. I don't see any window console. What did I do wrong? Thank you. Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbMS6P-wfFPRlDnW-9wgBxvroTD-4ks5ta1digaJpZM4SbIa9> .

alexbrainman · 2018-03-04T06:10:55Z

@devorel I don't understand your explanation. Please, try again.

Thank you

Alex

devorel · 2018-03-04T07:04:14Z

look this flug "windowsgui" need to cancel the window console 2018-03-04 8:11 GMT+02:00 Alex Brainman <notifications@github.com>:

…

@devorel <https://github.com/devorel> I don't understand your explanation. Please, try again. Thank you Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbGKA3GfzioH9g21mWe1-kn91DFSiks5ta4WggaJpZM4SbIa9> .

devorel · 2018-03-04T07:05:00Z

look
this flug "windowsgui" need to cancel the window console

different

alexbrainman · 2018-03-04T07:29:09Z

this flug "windowsgui" need to cancel the window console

I don't get any console windows. Both at version 1.9 and 1.10.

How did you build your executable? Did you see my command there #24232 (comment) ?
What is your command? Can I download your program to try it here?

Alex

devorel · 2018-03-04T07:51:28Z

Hi
i try your program , and i get it again
go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui

https://golang.org/dl/
go1.10.windows-amd64.msi | Installer | Windows | x86-64 | 106MB

alexbrainman · 2018-03-04T08:29:07Z

go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui

Looking at your screenshot, I can see you did something completely different. You used \ instead of / in your import path. Do not do that. Really use

go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui

command.

Alex

devorel · 2018-03-04T19:36:25Z

i tried but i have the problem yet. with 1.94 i dont have any problem!!!! 2018-03-04 10:30 GMT+02:00 Alex Brainman <notifications@github.com>:

…

go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui Looking at your screenshot, I can see you did something completely different. You used \ instead of / in your import path. Do not do that. Really use go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe github.com/alexbrainman/gowingui command. Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbLqz-bzIyaZ_AErSRQ0QuzQDNvALks5ta6YOgaJpZM4SbIa9> .

alexbrainman · 2018-03-04T20:51:06Z

I don't know how to reproduce your problem here. Sorry.

Alex

devorel · 2018-03-04T21:02:41Z

I don't also.. But i say . You have a problem with the flags in the last version! בתאריך 4 במרץ 2018 22:51,‏ "Alex Brainman" <notifications@github.com> כתב:

…

I don't know how to reproduce your problem here. Sorry. Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbIbk9LJs04TFPaSFN-f8uwbcvV7Rks5tbFPrgaJpZM4SbIa9> .

asticode · 2018-03-06T08:42:51Z

I've built a library that uses the -H windowsgui flag and some of my users are complaining it stopped working in GO 1.10 too. Unfortunately I didn't have time to investigate further but this issue seems to describe an actual problem therefore I'd like to help.

@alexbrainman which windows are you testing on?

alexbrainman · 2018-03-06T08:51:02Z

@asticode

some of my users are complaining it stopped working in GO 1.10 too. Unfortunately I didn't have time to investigate further but this issue seems to describe an actual problem therefore I'd like to help.

Perhaps your users use wrong import path to build their program, like I described in #24233. That will make Go 1.10 build executable without IMAGE_SUBSYSTEM_WINDOWS_GUI flag set.

@alexbrainman which windows are you testing on?

Windows 10.

Alex

devorel · 2018-03-06T08:56:29Z

NO, it's not! i v1.94 it's work good! i copied the command of alexbrainman <https://github.com/alexbrainman> ,and i get the window console yet 2018-03-06 10:52 GMT+02:00 Alex Brainman <notifications@github.com>:

…

@asticode <https://github.com/asticode> some of my users are complaining it stopped working in GO 1.10 too. Unfortunately I didn't have time to investigate further but this issue seems to describe an actual problem therefore I'd like to help. Perhaps your users use wrong import path to build their program, like I described in #24233 <#24233>. That will make Go 1.10 build executable without IMAGE_SUBSYSTEM_WINDOWS_GUI flag set. @alexbrainman <https://github.com/alexbrainman> which windows are you testing on? Windows 10. Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbPHPY9fvZT9H0uVJ_WyZv2N-cmyaks5tbk5BgaJpZM4SbIa9> .

alexbrainman · 2018-03-06T09:08:25Z

NO, it's not!
i v1.94 it's work good!
i copied the command of alexbrainman https://github.com/alexbrainman ,and
i get the window console yet

I believe you, but I cannot reproduce it myself. Perhaps others can. Sorry.

Alex

devorel · 2018-03-06T09:12:50Z

try download go1.10.windows-amd64.msi <https://dl.google.com/go/go1.10.windows-amd64.msi> Installer Windows x86-64 106MB https://golang.org/dl/ 2018-03-06 11:09 GMT+02:00 Alex Brainman <notifications@github.com>:

…

NO, it's not! i v1.94 it's work good! i copied the command of alexbrainman https://github.com/alexbrainman ,and i get the window console yet I believe you, but I cannot reproduce it myself. Perhaps others can. Sorry. Alex — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24232 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQGRbAr4K-1Tk_9cZhEBpIXK-tun97g_ks5tblJQgaJpZM4SbIa9> .

krasnovu · 2018-04-18T06:28:21Z

@alexbrainman, I have a similar problem on Go 1.10.1 (I could not downgrade to 1.9.3 to check if there was an error on this version) and I`ve found a way to reproduce it.

Steps to reproduce:

Check the GOPATH parameter in go env. For example, E:\Go.
In the console, change the directory using other letter case of part intersecting with GOPATH variable. For example, cd e:\go\src\site\project (here "e" and "go" in lowercase).
Build the project with the ldflags keys. For example go build -ldflags "-s -w -H=windowsgui".

P.S.: In my auto-builder project the second step looks like os.Chdir(dir).

alexbrainman · 2018-04-22T01:31:35Z

@alexbrainman, I have a similar problem on Go 1.10.1 (I could not downgrade to 1.9.3 to check if there was an error on this version) and I`ve found a way to reproduce it.

Yes, I can reproduce it here too now. I use these commands:

set MYHOME=c:\users\alex\dev
set GOROOT=%MYHOME%\go
set GOROOT_BOOTSTRAP=%MYHOME%\go1.4.3
set GOPATH=%MYHOME%
set PATH=%PATH%;%GOROOT%\bin
cd %GOPATH%\src\github.com\alexbrainman\gowingui
go build -ldflags "-H windowsgui" -v -o %tmp%\a.exe
pause

That creates %tmp%\a.exe that opens command window when it runs.

Thank you @krasnovu

Alex

gopherbot · 2018-04-25T06:36:19Z

Change https://golang.org/cl/109235 mentions this issue: cmd/go/internal/load: use strings.ToLower when comparing package directory names

alexbrainman · 2018-05-26T08:02:28Z

Just submitted the fix. Should we back port the fix to go1.10 and go1.9 ?

Alex

ianlancetaylor · 2018-05-27T06:52:00Z

@alexbrainman We shouldn't backport to 1.9 which doesn't have this problem anyhow.

A backport to 1.10 is OK with me if you think it is a good idea.

alexbrainman · 2018-06-01T23:43:27Z

We shouldn't backport to 1.9 which doesn't have this problem anyhow.

I agree, go1.9 is not broken with this issue, so we do not need to backport to go1.9.

A backport to 1.10 is OK with me if you think it is a good idea.

This issue did not affect me personally, so I do not know if it should be back ported or not. That is why I asked here. And it looks like no one cares about backporting this to go1.9. So I assume we don't want to backport this until we hear some complains.

Thank you, Ian.

Alex

hugows · 2018-06-29T20:25:58Z

PSA: for me, changing the GOPATH to the correct capitalization form e.g. "C:\Users\hugo\go" instead of "c:\users\hugo\go" is a workaround for on go 1.10.3.

gopherbot · 2018-08-10T21:02:59Z

Change https://golang.org/cl/129059 mentions this issue: cmd/go: fix -gcflags, -ldflags not applying to current directory

A flag setting like -gcflags=-e applies only to the packages named on the command line, not to their dependencies. The way we used to implement this was to remember the command line arguments, reinterpret them as pattern matches instead of package argument generators (globs), and apply them during package load. The reason for this complexity was to address a command-line like: go build -gcflags=-e fmt runtime The load of fmt will load dependencies, including runtime, and the load of runtime will reuse the result of the earlier load. Because we were computing the effective -gcflags for each package during the load, we had to have a way to tell, when encountering runtime during the load of fmt, that runtime had been named on the command line, even though we hadn't gotten that far. That would be easy if the only possible arguments were import paths, but we also need to handle go build -gcflags=-e fmt runt... go build -gcflags=-e fmt $GOROOT/src/runtime go build -gcflags=-e fmt $GOROOT/src/runt... and so on. The match predicates usually did their job well, but not always. In particular, thanks to symlinks and case-insensitive file systems and unusual ways to spell file paths, it's always been possible in various corner cases to give an argument that evalutes to the runtime package during loading but failed to match it when reused to determine "was this package named on the command line?" CL 109235 fixed one instance of this problem by making a directory pattern match case-insensitive on Windows, but that is incorrect in some other cases and doesn't address the root problem, namely that there will probably always be odd corner cases where pattern matching and pattern globbing are not exactly aligned. This CL eliminates the assumption that pattern matching and pattern globbing are always completely in agreement, by simply marking the packages named on the command line after the package load returns them. This means delaying the computation of tool flags until after the load too, for a few different ways packages are loaded. The different load entry points add some complexity, which is why the original approach seemed more attractive, but the original approach had complexity that we simply didn't recognize at the time. This CL then rolls back the CL 109235 pattern-matching change, but it keeps the test introduced in that CL. That test still passes. In addition to fixing ambiguity due to case-sensitive file systems, this new approach also very likely fixes various ambiguities that might arise from abuse of symbolic links. Fixes #24232. Fixes #24456. Fixes #24750. Fixes #25046. Fixes #25878. Change-Id: I0b09825785dfb5112fb11494cff8527ebf57966f Reviewed-on: https://go-review.googlesource.com/129059 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>

davecheney added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Mar 4, 2018

alexbrainman mentioned this issue Mar 4, 2018

cmd/go: "go get github.com\alexbrainman\gowingui" should succeed on Mac #24233

Open

bradfitz changed the title ~~Hi you have a bug compilation~~ cmd/link: Windows -H windowsgui stopped working in Go 1.10? Mar 4, 2018

bradfitz added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Mar 4, 2018

bradfitz added this to the Go1.11 milestone Mar 4, 2018

bradfitz added the help wanted label Mar 4, 2018

This was referenced Apr 18, 2018

Bundler on Windows creates console window. asticode/go-astilectron-bundler#16

Closed

On Windows a cmdline box is shown alogn the main window asticode/go-astilectron-demo#22

Closed

alexbrainman mentioned this issue Apr 24, 2018

cmd/go: build -ldflags="-s -w" invalid #25046

Closed

gopherbot closed this as completed in f7b625e May 26, 2018

rsc mentioned this issue Aug 10, 2018

cmd/go: go build produces binaries differently when package name has a trailing slash #24456

Closed

golang locked and limited conversation to collaborators Aug 10, 2019

gopherbot added the FrozenDueToAge label Aug 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/link: Windows -H windowsgui stopped working in Go 1.10? #24232

cmd/link: Windows -H windowsgui stopped working in Go 1.10? #24232

devorel commented Mar 3, 2018

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

devorel commented Mar 4, 2018 •

edited

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

asticode commented Mar 6, 2018

alexbrainman commented Mar 6, 2018

devorel commented Mar 6, 2018 via email

alexbrainman commented Mar 6, 2018

devorel commented Mar 6, 2018 via email

krasnovu commented Apr 18, 2018

alexbrainman commented Apr 22, 2018

gopherbot commented Apr 25, 2018

alexbrainman commented May 26, 2018

ianlancetaylor commented May 27, 2018

alexbrainman commented Jun 1, 2018

hugows commented Jun 29, 2018 •

edited

gopherbot commented Aug 10, 2018

cmd/link: Windows -H windowsgui stopped working in Go 1.10? #24232

cmd/link: Windows -H windowsgui stopped working in Go 1.10? #24232

Comments

devorel commented Mar 3, 2018

What version of Go are you using (go version)? 1.10

Does this issue reproduce with the latest release? yes ,just the last

What operating system and processor architecture are you using (go env)? windows 10 ,intel i7

What did you do?

What did you expect to see?

What did you see instead?

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

devorel commented Mar 4, 2018 • edited

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

alexbrainman commented Mar 4, 2018

devorel commented Mar 4, 2018 via email

asticode commented Mar 6, 2018

alexbrainman commented Mar 6, 2018

devorel commented Mar 6, 2018 via email

alexbrainman commented Mar 6, 2018

devorel commented Mar 6, 2018 via email

krasnovu commented Apr 18, 2018

alexbrainman commented Apr 22, 2018

gopherbot commented Apr 25, 2018

alexbrainman commented May 26, 2018

ianlancetaylor commented May 27, 2018

alexbrainman commented Jun 1, 2018

hugows commented Jun 29, 2018 • edited

gopherbot commented Aug 10, 2018

What version of Go are you using (`go version`)? 1.10

What operating system and processor architecture are you using (`go env`)? windows 10 ,intel i7

devorel commented Mar 4, 2018 •

edited

hugows commented Jun 29, 2018 •

edited