Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: C.GoString optimization broke build #24206

Closed
TocarIP opened this issue Mar 1, 2018 · 3 comments
Closed

runtime: C.GoString optimization broke build #24206

TocarIP opened this issue Mar 1, 2018 · 3 comments

Comments

@TocarIP
Copy link
Contributor

TocarIP commented Mar 1, 2018

CL 97523 breaks build for me:

--- FAIL: TestBrokenTestsWithoutTestFunctionsAllFail (0.19s)
        go_test.go:819: running testgo [test ./testdata/src/badtest/...]
        go_test.go:819: testgo failed as expected: signal: segmentation fault (core dumped)
        go_test.go:821: test did not run everything
        go_test.go:821: pattern FAIL.*badtest/badexec not found in standard output or standard error
--- FAIL: TestLocalImportsEasy (0.19s)
        go_test.go:1162: running testgo [build -o ./easy testdata/local/easy.go]
        go_test.go:1162: go [build -o ./easy testdata/local/easy.go] failed unexpectedly: signal: segmentation fault (core dumped)
--- FAIL: TestLocalImportsEasySub (0.18s)
        go_test.go:1168: running testgo [build -o ./easysub testdata/local/easysub/main.go]
        go_test.go:1168: go [build -o ./easysub testdata/local/easysub/main.go] failed unexpectedly: signal: segmentation fault (core dumped)
--- FAIL: TestLocalImportsHard (0.18s)
        go_test.go:1174: running testgo [build -o ./hard testdata/local/hard.go]
        go_test.go:1174: go [build -o ./hard testdata/local/hard.go] failed unexpectedly: signal: segmentation fault (core dumped)
--- FAIL: TestBadImportsEasy (0.64s)
        go_test.go:1216: running testgo [build -o ./easy testdata/#$%:, &()*;<=>?\^{}/easy.go]
        go_test.go:1216: error running ./easy: signal: segmentation fault (core dumped)
--- FAIL: TestBadImportsEasySub (0.64s)
        go_test.go:1223: running testgo [build -o ./easysub testdata/#$%:, &()*;<=>?\^{}/easysub/main.go]
        go_test.go:1223: error running ./easysub: signal: segmentation fault (core dumped)
--- FAIL: TestBadImportsHard (1.01s)
        go_test.go:1230: running testgo [build -o ./hard testdata/#$%:, &()*;<=>?\^{}/hard.go]
        go_test.go:1230: error running ./hard: signal: segmentation fault (core dumped)
--- FAIL: TestInternalPackagesInGOROOTAreRespected (0.19s)
        go_test.go:1243: running testgo [build -v ./testdata/testinternal]
        go_test.go:1243: testgo failed as expected: signal: segmentation fault (core dumped)
        go_test.go:1244: wrong error message for testdata/testinternal
        go_test.go:1244: pattern testinternal(\/|\\)p\.go\:3\:8\: use of internal package not allowed not found in standard output or standard error
...
FAIL    cmd/go  40.753s
@TocarIP
Copy link
Contributor Author

TocarIP commented Mar 1, 2018

@josharian
I think IndexByte needs to be called on per-page basis

@josharian
Copy link
Contributor

On my phone. Revert for now? Thanks.

If you have ideas about how to fix it, that’d be great. I’m running out of steam on that particular project.

@TocarIP
Copy link
Contributor Author

TocarIP commented Mar 1, 2018

Reverted in https://go-review.googlesource.com/c/go/+/97995
Closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants