Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: referrers does not respect -scope flag #24179

Closed
josharian opened this issue Feb 28, 2018 · 1 comment
Closed

x/tools/cmd/guru: referrers does not respect -scope flag #24179

josharian opened this issue Feb 28, 2018 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor 

$ guru -scope strconv referrers /Users/josh/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/controller_ref.go:#735
/Users/josh/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/controller_ref.go:24.6-24.19: references to func IsControlledBy(obj invalid type, owner invalid type) bool
/Users/josh/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/controller_ref_test.go:127.6-127.19: 	if !IsControlledBy(obj2, obj1) || !IsControlledBy(obj3, obj2) {
/Users/josh/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/controller_ref_test.go:127.37-127.50: 	if !IsControlledBy(obj2, obj1) || !IsControlledBy(obj3, obj2) {
/Users/josh/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/controller_ref_test.go:130.5-130.18: 	if IsControlledBy(obj3, obj1) {

I would expect no results, since strconv does not refer to kubernetes.

cc @alandonovan @DanielMorsing
@gopherbot gopherbot added this to the Unreleased milestone Feb 28, 2018
@josharian
Copy link
Contributor Author

Duplicate of #14747

@josharian josharian marked this as a duplicate of #14747 Feb 28, 2018
@golang golang locked and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@josharian @gopherbot