Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: don’t comment referencing a GerritBot change #24166

Closed
andybons opened this issue Feb 28, 2018 · 3 comments
Closed

x/build/cmd/gopherbot: don’t comment referencing a GerritBot change #24166

andybons opened this issue Feb 28, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@andybons
Copy link
Member

If a change originated from a PR, then you get two annotations saying the same thing. Example: #24068 (reference)

screen shot 2018-02-28 at 12 09 14 am

/cc @bradfitz
@andybons andybons self-assigned this Feb 28, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 28, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 28, 2018
@josharian
Copy link
Contributor

But only the gopherbot one triggers an email, which I personally like receiving. I say we leave the duplicates.

@andybons
Copy link
Member Author

@josharian I thought about that, too. Let’s consider this a semi-proposal then. I’ll keep it open and we can take some time to decide. This isn’t exactly high priority :)

/rant Also why doesn’t GitHub notify you via email of these metadata changes?

@andybons
Copy link
Member Author

andybons commented Mar 9, 2018

Meh. Let's just leave them so people get the emails.

@andybons andybons closed this as completed Mar 9, 2018
@golang golang locked and limited conversation to collaborators Mar 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@josharian @andybons @gopherbot