Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vgo: confused by ./ imports #24157

Closed
neild opened this issue Feb 27, 2018 · 4 comments
Closed

x/vgo: confused by ./ imports #24157

neild opened this issue Feb 27, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
vgo

Comments

@neild
Copy link
Contributor

neild commented Feb 27, 2018

When compiling a package containing import "./sub":

$ vgo build .
vgo: resolving import "./sub"
FindRepo: Get https://./sub?go-get=1: dial tcp: lookup .: no such host
vgo: import "github.com/neild/test" ->
	import "./sub": Get https://./sub?go-get=1: dial tcp: lookup .: no such host

I have no opinion on whether vgo should support relative imports, but it probably should at least recognize them.
@gopherbot gopherbot added this to the vgo milestone Feb 27, 2018
@bradfitz
Copy link
Contributor

Or this could be the chance to kill them.

@bradfitz
Copy link
Contributor

but it probably should at least recognize them.

Agreed. Enough to say "no", rather than tcp: lookup .: no such host

@rsc
Copy link
Contributor

rsc commented Mar 27, 2018

They're definitely not supposed to work, but they're not supposed to fail that badly. :-)

(They don't work from within GOPATH today even with the standard go command.)

@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 27, 2018
@gopherbot
Copy link

Change https://golang.org/cl/108378 mentions this issue: cmd/go/internal/vgo: vgo does not support relative imports

@golang golang locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
vgo
Development

No branches or pull requests
4 participants
@bradfitz @neild @rsc @gopherbot