Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: do not mail CLs with editor temp files, binaries #24139

Open
rsc opened this issue Feb 26, 2018 · 5 comments
Open

x/review/git-codereview: do not mail CLs with editor temp files, binaries #24139

rsc opened this issue Feb 26, 2018 · 5 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Feb 26, 2018

Motivated by #23800, git-codereview should probably refuse to mail CLs with editor temp files and binaries.
@gopherbot gopherbot added this to the Unreleased milestone Feb 26, 2018
@mvdan
Copy link
Member

mvdan commented Mar 1, 2018

How about disallowing non-printable characters in commit messages too? For example, see https://go-review.googlesource.com/c/go/+/97635, which shows on my terminal as:

keep exiting goroutines^P.

@rsc
Copy link
Contributor Author

rsc commented Mar 5, 2018

OK sure do that too.

@rsc rsc mentioned this issue Mar 5, 2018
Closed
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 11, 2018
@ysmolski
Copy link
Member

ysmolski commented Mar 20, 2018 •
edited

What kind of binaries should it disallow? We have repositories with images, for instance.

update: I created a patch for the case of temp editor files and non-printable characters.

@gopherbot
Copy link

Change https://golang.org/cl/101755 mentions this issue: git-codereview: forbig mailing editor temp files

@ysmolski
Copy link
Member

@bradfitz, I have implemented this features and then I read this: #10658

It says that for binaries we should aim for the fix on server side of gerrit. Does my work on this ticket (which does not touch binaries) still relevant?

Thanks.

gopherbot pushed a commit to golang/review that referenced this issue Mar 30, 2018
@ysmolski @bradfitz
git-codereview: forbid mailing editor temp files
febe82b 
"mail" command rejects *~, #*# and .#* filenames.

Also it should reject commit messages with non-printable characters,
because these are impossible to spot in the review.

For golang/go#24139

Change-Id: I3544e3c34c5ac9f55a7808264de4535bc455bd0a
Reviewed-on: https://go-review.googlesource.com/101755
Run-TryBot: Yury Smolsky <yury@smolsky.by>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@rsc @ysmolski @andybons @mvdan @gopherbot