Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vgo: create go.modverify by default #24116

Closed
FiloSottile opened this issue Feb 25, 2018 · 1 comment
Closed

x/vgo: create go.modverify by default #24116

FiloSottile opened this issue Feb 25, 2018 · 1 comment
Labels
FrozenDueToAge
Milestone
vgo

Comments

@FiloSottile
Copy link
Contributor

FiloSottile commented Feb 25, 2018 •
edited

The security provided by go.modverify should not be opt-in.

I elaborated on why locking hashes into repositories is so important at https://groups.google.com/d/msg/golang-dev/MNQwgYHMEcY/Jl-piUJ_CgAJ

There is no reason we should encourage not using it, at least not until we have a solid story about alternative verification methods.
@gopherbot gopherbot added this to the vgo milestone Feb 25, 2018
@FiloSottile FiloSottile mentioned this issue Feb 25, 2018
Closed
@rsc
Copy link
Contributor

rsc commented Mar 30, 2018

As I wrote on #24117:

Not yet. We're fixing one thing at a time. The first thing to fix is management of versions at all. The second thing is verification. There's no need to do both at once. We've gotten by this long with "go get" with no modverify. Let's get versions into go first, and then turn our attention to verifying.

Especially if we do have a solid plan for alternate verification methods, there is no point to littering everyone's repos with go.modverify files that will not be necessary in the long run.

@rsc rsc closed this as completed Mar 30, 2018
@golang golang locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
vgo
Development

No branches or pull requests
3 participants
@rsc @FiloSottile @gopherbot