Skip to content

x/vgo: git submodules are not downloaded #24094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tgulacsi opened this issue Feb 24, 2018 · 3 comments
Closed

x/vgo: git submodules are not downloaded #24094

tgulacsi opened this issue Feb 24, 2018 · 3 comments
Labels
FrozenDueToAge
Milestone
vgo

Comments

@tgulacsi
Copy link
Contributor

What version of Go are you using (go version)?

1.10

What operating system and processor architecture are you using (go env)?

linux/amd64

What did you do?

:gthomas@redpath: ~/src/github.com/tgulacsi/go/dbcsv/csvdump
$ vgo build -o /tmp/csvdump
vgo: resolving import "gopkg.in/goracle.v2"
vgo: finding gopkg.in/goracle.v2 (latest)
vgo: adding gopkg.in/goracle.v2 v1.1.15-gopkgin-v2.1.15
# gopkg.in/goracle.v2
../../../../../v/gopkg.in/goracle.v2@v1.1.15-gopkgin-v2.1.15/conn.go:20:10: fatal error: 'dpiImpl.h' file not found
#include "dpiImpl.h"
         ^~~~~~~~~~~
1 error generated.

One issue is that vgo resolves gopkg.in/goracle.v2 as gopkg.in/goracle.v2 v1.1.15-gopkgin-v2.1.15, even if I put gopkg.in/goracle.v2/v2 v2.1.15 into the go.mod file,

another issue is that though it downloads goracle.v2, it does not download its odpi submodule.
Will submodules be supported, or should we find a workaround?
(Workaround: use go generate to download the submodule and rsync into another dir)
If possible, provide a recipe for reproducing the error.
@gopherbot gopherbot added this to the vgo milestone Feb 24, 2018
@tgulacsi
Copy link
Contributor Author

I can confirm that copying the C source out from the submodule solves as a workaround.

@tgulacsi tgulacsi mentioned this issue Feb 24, 2018
Closed
@rsc
Copy link
Contributor

rsc commented Mar 30, 2018

Submodules will not be supported, sorry. That's getting back into the version control detail world that we're trying to get "go get" out of.

@rsc rsc closed this as completed Mar 30, 2018
@myitcv myitcv changed the title x/vgo: submodules are not downloaded x/vgo: git submodules are not downloaded Apr 13, 2018
@myitcv
Copy link
Member

myitcv commented Apr 13, 2018

Just updated the title here to confirm this discussion is about git submodules not being supported. As distinct from vgo Go modules (and submodules).

@myitcv myitcv mentioned this issue Jul 31, 2018
Closed
@icedream icedream mentioned this issue Nov 30, 2018
Closed
@ansemjo ansemjo mentioned this issue Feb 19, 2019
Closed
ansemjo added a commit to ansemjo/go-shamirsplit that referenced this issue Feb 19, 2019
@ansemjo
update to go modules and quasi-vendor dsprenkels/sss-go

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
9b9ab5b 
vendor the sss-go code and its submodules to work around:
- dsprenkels/sss-go#2
- golang/go#24094 (comment)
@golang golang locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
vgo
Development

No branches or pull requests
4 participants
@rsc @tgulacsi @myitcv @gopherbot