Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: rewrite history to remove 14.6 MB blob #24020

Closed
andybons opened this issue Feb 21, 2018 · 7 comments
Closed

x/tools: rewrite history to remove 14.6 MB blob #24020

andybons opened this issue Feb 21, 2018 · 7 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@andybons
Copy link
Member

andybons commented Feb 21, 2018 •
edited

Log of what was done:
On release-branch.go1.10:

  • git reset --hard HEAD~4
  • git push -f <internal url for tools Gerrit repo> localbranch:release-branch.go1.10
  • Resulted in HEAD at 25101aad - (godoc,cmd/getgo: update download links to dl.google.com)

On master:

  • git reset --soft HEAD~2
  • git add .
  • git commit
  • git push -f <internal url for tools Gerrit repo>

The above (for master) was repeated three times due to commit message issues. At one point, HEAD was:

  • 25b48f88
  • 84831f73
  • ab0261ad

Until I completely reverted the commit and reset HEAD to 07fd8470d635b985c9c749fa83bdbc2f20b35d42 - godoc/dl: provide JSON feed of releases
@andybons andybons self-assigned this Feb 21, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2018
@bradfitz
Copy link
Contributor

Original bad CL with 14.6 MB godoc binary:
https://go-review.googlesource.com/c/tools/+/96055

Added to x/tools master as 4a5950d5e6ace466ebfb8c804312e5da044e2feb
And chery-picked to release-branch.go1.10 as https://go-review.googlesource.com/c/tools/+/96056 (2b679cfe11e767351d90b4140efd41a892327422)

@bradfitz
Copy link
Contributor

x/tools master was force-reset back to:
https://go.googlesource.com/tools/+/07fd8470d635b985c9c749fa83bdbc2f20b35d42

@bradfitz
Copy link
Contributor

Bug to make sure this doesn't happen again: #10658

@bradfitz
Copy link
Contributor

x/tools release-branch.go.10 was reset back to: https://go.googlesource.com/tools/+/25101aadb97aa42907eee6a238d6d26a6cb3c756

@andybons
Copy link
Member Author

Updated comment with log.

@robpike
Copy link
Contributor

robpike commented Feb 22, 2018

I just knew in my heart this would lead back to a blunder I made.

@andybons
Copy link
Member Author

Closing as there doesn’t appear to be any issues. Please reopen if anything pops up.

@mark-rushakoff mark-rushakoff mentioned this issue Nov 20, 2018
Closed
@golang golang locked and limited conversation to collaborators Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @robpike @gopherbot