Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: run ssacheck mode for all architectures, not just amd64 #24016

Open
josharian opened this issue Feb 21, 2018 · 2 comments
Open

x/build: run ssacheck mode for all architectures, not just amd64 #24016

josharian opened this issue Feb 21, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

We have an amd64 ssacheck builder. That builder should compile std+cmd for all architectures, not just native. That would have prevented or at least caught #24014.
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 21, 2018
@bradfitz
Copy link
Contributor

We already have a bunch of misc-compile builders. Can we just make them ssacheck too?

@josharian
Copy link
Contributor Author

SGTM. It’ll make them a bit slower, but that seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @josharian @gopherbot