Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools: fix dep install for x/tools? #23981

Closed
mcandre opened this issue Feb 21, 2018 · 6 comments
Closed

x/tools: fix dep install for x/tools? #23981

mcandre opened this issue Feb 21, 2018 · 6 comments

Comments

@mcandre
Copy link

mcandre commented Feb 21, 2018

dep is currently unable to resolve Go's x/tools due to an issue with directories that lack Go source files. Could we add a version.go or similar nonce file at the top of golang.org/x/tools, as a workaround?

@bradfitz
Copy link
Contributor

Is there an open dep bug about this?

@dominikh
Copy link
Member

dominikh commented Feb 21, 2018

Sounds like golang/dep#1272 or possibly golang/dep#899

@bradfitz bradfitz changed the title Fix dep install for x/tools x/tools: fix dep install for x/tools? Feb 21, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2018
@bradfitz bradfitz added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Feb 21, 2018
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@mcandre
Copy link
Author

mcandre commented Mar 21, 2018

@gopherbot

Lol this is still an issue. Just because I didn't respond to a not-question doesn't mean that this issue is magically resolved.

So dep appears to be a nascent state, unable to install even basic Go utliities, due to dep's requirement that all repositories feature Go code at the top directory level. I am proposing a workaround: Declare the utility version in a top level version.go file, or put some other kind of nonce there, so that dep can install these x/... components.

@ianlancetaylor
Copy link
Contributor

I think we are waiting to see whether dep is going to fix the problem. If dep makes a definitive decision that they will not support this kind of repo--which seems like an odd choice to me--then we can consider changing the repo here.

@spf13 spf13 removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Mar 26, 2018
@rsc
Copy link
Contributor

rsc commented Mar 26, 2018

Top-level directories that don't have Go code in them are completely fine. We should not turn inadequacies in tools into changes forced into every repo in existence. Even tools we own like Dep.

@rsc rsc closed this as completed Mar 26, 2018
@golang golang locked and limited conversation to collaborators Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants