Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: PR fails import if it has a Change-Id in the description #23931

Closed
andybons opened this issue Feb 19, 2018 · 1 comment
Closed

x/build/cmd/gerritbot: PR fails import if it has a Change-Id in the description #23931

andybons opened this issue Feb 19, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@andybons
Copy link
Member

If Change-Id is present in the description, then it will fail to import due to it not being in the footer of a change:

remote: Processing changes: refs: 1, done             remote: 
remote: ERROR: [4ac3a5f] missing Change-Id in commit message footer        
remote: 
remote: Hint: A potential Change-IdChange-Id was found, but it was not in the footer (last paragraph) of the commit message.        
remote: 
remote: Hint: To automatically insert Change-Id, install the hook:        
remote: curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg ; chmod +x `git rev-parse --git-dir`/hooks/commit-msg        
remote: And then amend the commit:        
remote:   git commit --amend        
remote: 
To https://go.googlesource.com/crypto
 ! [remote rejected] HEAD -> refs/for/master ([4ac3a5f] missing Change-Id in commit message footer)
error: failed to push some refs to 'https://go.googlesource.com/crypto'
; err: exit status 1
2018/02/19 12:58:47 Updating data from log *maintner.netMutSource ...
@andybons andybons self-assigned this Feb 19, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 19, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 19, 2018
@andybons andybons mentioned this issue Feb 19, 2018
Closed
@bradfitz bradfitz mentioned this issue Feb 20, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/95636 mentions this issue: cmd/gerritbot: account for a Change-Id in the PR description

@golang golang locked and limited conversation to collaborators Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@andybons @gopherbot