/cc @ianlancetaylor

Can you tell us how to recreate the problem?

Actually i have 340 packages with tests and only one is having this issue. It seems the file is not different from the others. I still have to identify what's causing the issue or how to replicate it. I'll let you know very soon.

I worked and found what's causing the issue. I have this function (it is only an example but it's recreating the issue). With the function below I don't have the issue:

func updateItemsChildrenKeys(itemsColl data.PhysicalItemsCollection, items []data.Item, request *command.InternalRequest, reply *command.Reply) errors.Err {
    up := itemsColl.StartUpdate()
    defer up.EndUpdate()

    for _, item := range items {
        _, _ = up.ByKeyForUpdate(item.Key())
        if item.ParentKey() != nil {

        }

    }

    return nil
}

but when I add the else the issue appears:

func updateItemsChildrenKeys(itemsColl data.PhysicalItemsCollection, items []data.Item, request *command.InternalRequest, reply *command.Reply) errors.Err {
    up := itemsColl.StartUpdate()
    defer up.EndUpdate()

    for _, item := range items {
        _, _ = up.ByKeyForUpdate(item.Key())
        if item.ParentKey() != nil {

        }else{
            
        }

    }

    return nil
}

I was able to replicate the issue with this code too:

if len(attributes) > 0{
			if item != nil{
                            //DO SOMETHING
			}
		}else{
                    //DO SOMETHING
		}

with this code works:

if len(attributes) > 0 && item != nil{
  //DO SOMETHING
}
if len(attributes) > 0 && item == nil{
 //DO SOMETHING
}

It seems the issue is in somewhere in the ELSE clause handler

Thanks. For clarity, can you show us a complete, self-contained example, along with the commands you use to recreate the problem? That would save time on our end. Thanks.

Atttached .go file and its related tests. It is veri very very very simple but it reproduce the issue. Let me know

test.zip

Thanks. The problem only arises because your main.go file has not been through gofmt. If I run gofmt on the file, the problem disappears.

The problem is specifically }else{. If I change that to } else{ (adding a space after the }, as gofmt does) then the problem does not occur.

main.go:

package main

func main(){
	var attributes []string
	var item interface{}

	if len(attributes) > 0{
		if item != nil{
			//DO SOMETHING
		}
	}else{
		//DO SOMETHING
	}
}

main_test.go:

package main

import (
	"testing"
)

func TestMain(t *testing.T) {
	main()
}

go test -cover

# cover _/tmp/x/src/a
panic: overlapping edits: [142,146)->"", [143,143)->"GoCover_0_366235663035346337313436.Count[3] = 1;"

goroutine 1 [running]:
cmd/internal/edit.(*Buffer).Bytes(0xc0000f2c00, 0xc0000f0120, 0x6216a0, 0xc000110300)
	/home/iant/go/src/cmd/internal/edit/edit.go:79 +0x515
main.annotate(0x7ffeec2bb74a, 0x14)
	/home/iant/go/src/cmd/cover/cover.go:332 +0x468
main.main()
	/home/iant/go/src/cmd/cover/cover.go:88 +0x180
FAIL	_/tmp/x/src/a [build failed]

😮 got it

Change https://golang.org/cl/98935 mentions this issue: cmd/cover: don't crash on non-gofmt'ed input

CL 98935 OK for Go 1.10.1

Change https://golang.org/cl/102786 mentions this issue: [release-branch.go1.10] cmd/cover: don't crash on non-gofmt'ed input

I had this problem with go 1.10.3
Adding the spaces in the else clauses fixed it.
I was testing the coverage with GoLand so it might be their tools aren't updated

@AgustinBanchio if you test without GoLand can you still reproduce the issue?

@AgustinBanchio This problem is fixed in 1.10.1. If you are seeing the exact same problem, then you are most likely running an older version of the toolchain. If you are sure that you are not, then you have found a different problem. Please open a new issue with reproduction instructions. Thanks.