Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: ReverseProxy, CloseNotify and HTTP 1.1 pipelining #23921

Closed
juliens opened this issue Feb 19, 2018 · 3 comments
Closed

net/http/httputil: ReverseProxy, CloseNotify and HTTP 1.1 pipelining #23921

juliens opened this issue Feb 19, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@juliens
Copy link
Contributor

juliens commented Feb 19, 2018

What version of Go are you using (go version)?

go version go1.10 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/juliens/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/juliens/dev/go"
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build191630190=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I use httputil.ReverseProxy in order to proxify an apt mirror.

What did you expect to see?

My reverse proxy works when I try to do apt update/install

What did you see instead?

apt receive:

502 Bad Gateway

and in reverse proxy logs:

2018/02/16 13:52:30 http: proxy error: context canceled

More

To reproduce, you can do this reverse proxying (on a linux distrib with apt)

package main

import (
   "net/http/httputil"
   "net/url"
   "net/http"
)

func main() {
   backend, _ := url.Parse("http://archive.ubuntu.com")
   proxy := httputil.NewSingleHostReverseProxy(backend)

   handler := http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
      proxy.ServeHTTP(rw, req)
   })

   http.ListenAndServe(":80", handler)
}

Then modify in your /etc/hosts

127.0.0.1   archive.ubuntu.com

and try

apt update

or

apt install ...
@namusyaka namusyaka changed the title httputil.ReverseProxy, CloseNotify and HTTP 1.1 pipelining net/http/httputil: ReverseProxy, CloseNotify and HTTP 1.1 pipelining Feb 19, 2018
@namusyaka
Copy link
Member

/cc @bradfitz @tombergan

@fraenkel
Copy link
Contributor

Works for me using ubuntu 17.10 and Go 1.10

@bradfitz bradfitz self-assigned this Feb 19, 2018
@bradfitz bradfitz added this to the Go1.11 milestone Feb 19, 2018
@juliens juliens mentioned this issue Mar 30, 2018
Merged
@mmatur mmatur mentioned this issue Jun 18, 2018
Merged
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 13, 2018
@gopherbot
Copy link

Change https://golang.org/cl/123875 mentions this issue: net/http: don't cancel Request.Context on pipelined Server requests

@juliens juliens mentioned this issue Jul 17, 2018
Closed
@golang golang locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
5 participants
@bradfitz @juliens @namusyaka @fraenkel @gopherbot