New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/release: go1.10.windows-{386,amd64} zip distributions contain "go.exe~" and "dist.exe~" #23894
Comments
what go.exe~ and dist.exe~ can do? |
This is a matter of simply not cleaning up everything when building the release via our automated process. This will be fixed. |
@andybons Is this issue open for work ? |
@vbmade2000 meaning is it available for you to work on it? Sure. |
@andybons Cool. Thanks. |
@alexbrainman any idea what’s going on? |
@andybons Nope. Didn't get time to investigate it. I'll check today. |
go.exe~ file is created when go.exe rebuilds itself. When Windows process is running, its executable cannot be deleted. So how would go.exe replace its executable when it needs to rebuild itself? As we discovered long time ago, you cannot delete executable, but it is OK to rename executable. So that is what we do - when go.exe try to replace itself and fails, it renames go.exe into go.exe~, and then it can write new go.exe. That leaves go.exe~ behind, because cmd/go process still cannot remove go.exe~. go.exe~ can be removed later once its process exits, but I suspect we never bother to do that. It would be the same story for dist.exe~. You can search for I suspect (I did not actually check) you should just modify release.go to have postBuildCleanFiles include both go.exe~ and dist.exe~ files. I hope it helps. Alex |
I was able to reproduce the issue. There are files called I checked SHA256 value and found it same as given on download site. |
@alexbrainman Makes sense. I want to test your suggestion. Can you tell me how to do that on local system ? |
@alexbrainman that helps immensely. Thank you :) |
@andybons Can I create CL for that ? |
@vbmade2000 yep. go for it. |
Change https://golang.org/cl/111375 mentions this issue: |
Change https://golang.org/cl/111518 mentions this issue: |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?1.10
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?Windows, 386, amd64
What did you do?
Download the go1.10.windows-amd64.zip archive. Extract it or otherwise inspect its contents.
It seems to contain
go/bin/go.exe~
The text was updated successfully, but these errors were encountered: