Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestArenaCollision failing on Plan 9 #23860

Closed
0intro opened this issue Feb 15, 2018 · 2 comments
Closed

runtime: TestArenaCollision failing on Plan 9 #23860

0intro opened this issue Feb 15, 2018 · 2 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.11

Comments

@0intro
Copy link
Member

0intro commented Feb 15, 2018 •
edited
Loading

CL 85887 added TestArenaCollision. This test is failing on Plan 9.

--- FAIL: TestArenaCollision (0.09s)
	malloc_test.go:175: === RUN   TestArenaCollision
		--- FAIL: TestArenaCollision (0.04s)
			malloc_test.go:201: allocation 0x308ba000 in reserved region [0x30800000, 0x30c00000)
		FAIL
		
		(exit status exit status: 'runtime.test 3200: 1')
FAIL
FAIL	runtime	45.682s

See https://build.golang.org/log/a40d99236bc32852c7bcef9614b51b7c3f5dae69
@0intro 0intro added this to the Go1.11 milestone Feb 15, 2018
@0intro 0intro self-assigned this Feb 15, 2018
@0intro 0intro changed the title runtime: TestArenaCollision failing on Plan 9 runtime: TestArenaCollision failing on 32-bit Plan 9 Feb 15, 2018
@0intro 0intro changed the title runtime: TestArenaCollision failing on 32-bit Plan 9 runtime: TestArenaCollision failing on Plan 9 Feb 16, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/94776 mentions this issue: runtime: don't ignore address hint for sysReserve in Plan 9

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/97595 mentions this issue: runtime: don't try to shrink address space with brk in Plan 9

gopherbot pushed a commit that referenced this issue Feb 28, 2018
@0intro
runtime: don't try to shrink address space with brk in Plan 9
c2cdfbd 
Plan 9 won't let brk shrink the data segment if it's shared with
other processes (which it is in the go runtime).  So we keep track
of the notional end of the segment as it moves up and down, and
call brk only when it grows.

Corrects CL 94776.

Updates #23860.
Fixes #24013.

Change-Id: I754232decab81dfd71d690f77ee6097a17d9be11
Reviewed-on: https://go-review.googlesource.com/97595
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Feb 28, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@0intro @gopherbot