Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: check for Signed-off-by lines before pushing to Gerrit #23852

Closed
tklauser opened this issue Feb 15, 2018 · 2 comments
Closed

x/review/git-codereview: check for Signed-off-by lines before pushing to Gerrit #23852

tklauser opened this issue Feb 15, 2018 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

tklauser commented Feb 15, 2018 •
edited

Recently https://golang.org/cl/93935 was submitted where the commit message contained a Signed-off-by line (there are also a few cases of these lines in already submitted CLs). These SOB lines are not used by the Go project and https://golang.org/wiki/CommitMessage was thereupon updated by @bradfitz

It would be nice if git-codereview would let the user know that these lines are unnecessary (with a link to the wiki page) or even refuse to push a CL containing such a line to Gerrit.
@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2018
@bradfitz
Copy link
Contributor

That would only help people using git-codereview. Now that we accept PRs, those lines will come in via GitHub anyway.

I don't think this is worth doing.

I think the right place to do this is in bots doing Gerrit reviews automatically, which is #18548

@tklauser
Copy link
Member Author

#18548 is a lot nicer. Guess I didn't search hard enough for existing issues...

@golang golang locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @tklauser @gopherbot