Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: closing PR doesn't abandon CL #23850

Closed
bradfitz opened this issue Feb 15, 2018 · 8 comments
Closed

x/build/cmd/gerritbot: closing PR doesn't abandon CL #23850

bradfitz opened this issue Feb 15, 2018 · 8 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

This PR was closed by the user:

#23843 (comment)

But GerritBot didn't abandon the CL:

https://go-review.googlesource.com/c/go/+/94315
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 15, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 15, 2018
@tklauser
Copy link
Member

tklauser commented Apr 4, 2018

Another case: PR golang/sys#8 was closed and https://golang.org/cl/103858 wasn't abandoned.

@agnivade agnivade mentioned this issue Apr 10, 2018
Closed
@dmitshur dmitshur assigned dmitshur and unassigned andybons Jan 24, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Jan 24, 2019 •
edited
Loading

Another occurrence: PR #25817 was closed, but its associated imported Gerrit CL 117795 was not.

I'll aim to resolve this in the coming weeks.

Edit from Dec 2019: This fell off my radar. It happened again in CL 113258.

@ALTree ALTree mentioned this issue Apr 10, 2020
Closed
@stamblerre
Copy link
Contributor

stamblerre commented May 15, 2020 •
edited
Loading

@dmitshur: If it's okay with you, I can try to take a look at this. Created a PR with which to test this in dry-run mode: golang/vscode-go#55.

@dmitshur
Copy link
Contributor

Sure. This issue must've overflowed off my list yet again. Thanks.

@dmitshur dmitshur removed their assignment May 15, 2020
@stamblerre
Copy link
Contributor

stamblerre commented May 15, 2020 •
edited
Loading

Hm, looks like golang/vscode-go#55 was closed correctly. Is it possible this was already fixed, or is this just something that happens intermittently?

Edit: I now see that I had the issue backwards. Closing the PR doesn't abandon the CL, but abandoning the CL does close the PR. Will try again on golang/vscode-go#56.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/234179 mentions this issue: cmd/gerritbot: abandon CLs imported from PRs that have been closed

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/234889 mentions this issue: cmd/gerritbot: use secret keeper only when run in GCE

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/234240 mentions this issue: another test PR for https://github.com/golang/go/issues/23850

gopherbot pushed a commit to golang/build that referenced this issue May 21, 2020
@dmitshur
cmd/gerritbot: use secret manager only when run in GCE
4872bff 
Restore the ability to test gerritbot locally in dry-run mode.

Update some references to compute metadata with secret manager,
since that is what's used now.

Also add a safety check at the top of postGitHubMessageNoDup.
This increases confidence that it is safe to use dry-run mode,
and may help in case it's ever called in non-dry-run mode.

For golang/go#37171.
For golang/go#23850.

Change-Id: I6d7ea228294fc07b6167317ddcf066507e0c0d08
Reviewed-on: https://go-review.googlesource.com/c/build/+/234889
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@dmitshur dmitshur mentioned this issue Jul 10, 2020
Closed
@golang golang locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@bradfitz @andybons @tklauser @FiloSottile @dmitshur @stamblerre @gopherbot