You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If gerritbot successfully added the PR author as a reviewer or as CC to the Gerrit CL, it makes little sense to forward comment/review updates to the Github pull request in the form of comments.
The text was updated successfully, but these errors were encountered:
I also suspect we'll need some fancier GitHub email <-> Gerrit email mapping at some point. A good percentage of users have different emails in their Git Author lines vs their Gerrit (Google) account.
It also seems a bit too spammy if a CL is very active. Assuming that the purpose of these comments is to keep the author notified, I think we should limit them to one per day.
Would also be interesting to not notify about a comment that the author themselves posted, but that seems tricky. If we knew who the author was on Gerrit, we wouldn't be posting the notifications to begin with.
It also seems a bit too spammy if a CL is very active. Assuming that the purpose of these comments is to keep the author notified, I think we should limit them to one per day.
It’s unlikely we will implement a digest. This is the exact reason /comments off exists (plus GitHub has its own notification settings).
Agreed that it should default to comments off if the author is also getting emailed in Gerrit.
For example: #23809
If gerritbot successfully added the PR author as a reviewer or as CC to the Gerrit CL, it makes little sense to forward comment/review updates to the Github pull request in the form of comments.
The text was updated successfully, but these errors were encountered: