Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strconv: Unquote has custom for-loop-based contains implementation #23821

Closed
dgryski opened this issue Feb 14, 2018 · 2 comments
Closed

strconv: Unquote has custom for-loop-based contains implementation #23821

dgryski opened this issue Feb 14, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Milestone
Unplanned

Comments

@dgryski
Copy link
Contributor

dgryski commented Feb 14, 2018

It should use one of the optimized assembly routines from strings (or I guess the runtime if you don't want to introduce a dependency on strings from strconv).

go/src/strconv/quote.go

Line 421 in c10e614

// contains reports whether the string contains the byte c.

@josharian
Copy link
Contributor

Probably depends on #19792

@ianlancetaylor ianlancetaylor added Performance NeedsFix The path to resolution is known, but the work has not been done. labels Mar 28, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 28, 2018
@gopherbot
Copy link

Change https://golang.org/cl/116755 mentions this issue: strconv: use bytealg implementation of IndexByteString

@golang golang locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@josharian @dgryski @ianlancetaylor @gopherbot