Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/trace: TestTraceSymbolize failing on Plan 9 #23816

Closed
0intro opened this issue Feb 13, 2018 · 3 comments
Closed

runtime/trace: TestTraceSymbolize failing on Plan 9 #23816

0intro opened this issue Feb 13, 2018 · 3 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.11

Comments

@0intro
Copy link
Member

0intro commented Feb 13, 2018 •
edited

CL 92916 added GOMAXPROCS test to TestTraceSymbolize. This test is failing on Plan 9.

--- FAIL: TestTraceSymbolize (0.24s)
	trace_stack_test.go:282: Did not match event Gomaxprocs with stack
		  runtime.startTheWorld			 :0
		  runtime.GOMAXPROCS			 :0
		  runtime/trace_test.TestTraceSymbolize	 :0
		  testing.tRunner			 :0
		
		Seen 3 events of the type
		Offset 120
		  runtime.startTheWorld			/go/src/runtime/proc.go:973
		  runtime.StartTrace			/go/src/runtime/trace.go:258
		  runtime/trace.Start			/go/src/runtime/trace/trace.go:46
		  runtime/trace_test.TestTraceSymbolize	/go/src/runtime/trace/trace_stack_test.go:30
		  testing.tRunner			/go/src/testing/testing.go:777
		Offset 510
		  runtime.gcStart			/go/src/runtime/mgc.go:1371
		  runtime.GC				/go/src/runtime/mgc.go:1112
		  runtime/trace_test.TestTraceSymbolize	/go/src/runtime/trace/trace_stack_test.go:110
		  testing.tRunner			/go/src/testing/testing.go:777
		Offset 576
		  runtime.gcMarkTermination	/go/src/runtime/mgc.go:1647
		  runtime.gcMarkDone		/go/src/runtime/mgc.go:1513
		  runtime.gcBgMarkWorker	/go/src/runtime/mgc.go:1912
FAIL
FAIL	runtime/trace	22.479s

See https://build.golang.org/log/d1188aea517d7d463c85960dac4c1ac9bb49b5e0
@0intro 0intro added this to the Go1.11 milestone Feb 13, 2018
@0intro 0intro self-assigned this Feb 13, 2018
@0intro
Copy link
Member Author

0intro commented Feb 13, 2018

The GOMAXPROCS test doesn't work when the value of GOMAXPROCS doesn't change.

Since the test calls runtime.GOMAXPROCS(1), it will fail on machines where GOMAXPROCS=1, which is the case on uniprocessor machines by default.

@0intro
Copy link
Member Author

0intro commented Feb 13, 2018 •
edited

The issue can be reproduced on Linux as well:

$ go test -v -run TestTraceSymbolize
=== RUN   TestTraceSymbolize
--- PASS: TestTraceSymbolize (0.20s)
PASS
ok      runtime/trace   0.207s
$ GOMAXPROCS=1 go test -v -run TestTraceSymbolize
=== RUN   TestTraceSymbolize
--- FAIL: TestTraceSymbolize (0.20s)
        trace_stack_test.go:282: Did not match event Gomaxprocs with stack
                  runtime.startTheWorld                  :0
                  runtime.GOMAXPROCS                     :0
                  runtime/trace_test.TestTraceSymbolize  :0
                  testing.tRunner                        :0

                Seen 3 events of the type
                Offset 114
                  runtime.startTheWorld                 /go/src/runtime/proc.go:973
                  runtime.StartTrace                    /go/src/runtime/trace.go:258
                  runtime/trace.Start                   /go/src/runtime/trace/trace.go:46
                  runtime/trace_test.TestTraceSymbolize /go/src/runtime/trace/trace_stack_test.go:30
                  testing.tRunner                       /go/src/testing/testing.go:777
                Offset 447
                  runtime.gcStart                       /go/src/runtime/mgc.go:1371
                  runtime.GC                            /go/src/runtime/mgc.go:1112
                  runtime/trace_test.TestTraceSymbolize /go/src/runtime/trace/trace_stack_test.go:110
                  testing.tRunner                       /go/src/testing/testing.go:777
                Offset 508
                  runtime.gcMarkTermination     /go/src/runtime/mgc.go:1647
                  runtime.gcMarkDone            /go/src/runtime/mgc.go:1513
                  runtime.gcBgMarkWorker        /go/src/runtime/mgc.go:1912
FAIL
exit status 1
FAIL    runtime/trace   0.205s

@gopherbot
Copy link

Change https://golang.org/cl/93735 mentions this issue: runtime/trace: fix TestTraceSymbolize when GOMAXPROCS=1

@golang golang locked and limited conversation to collaborators Feb 13, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@0intro @gopherbot