Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: help list not ordered correctly #23791

Closed
rsc opened this issue Feb 12, 2018 · 3 comments
Closed

cmd/go: help list not ordered correctly #23791

rsc opened this issue Feb 12, 2018 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@rsc
Copy link
Contributor

rsc commented Feb 12, 2018

"go help" shows a list of commands that follows the list in the source code.
The one in the source code is meant to be kept sorted.
Clearly it is not: "go bug" appears between "go env" and "go fix"
in the "go help" output. We should fix that.
@rsc rsc added this to the Go1.11 milestone Feb 12, 2018
@nathanwilk7
Copy link
Contributor

Fixed in https://go-review.googlesource.com/c/go/+/93416 and submitted for review.

Changed order of elements in base.Commands in main.go so that output is alphabetical.

This is my first PR for go, any feedback is appreciated, thanks.

@bradfitz bradfitz added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. labels Feb 13, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/93416 mentions this issue: cmd/go: put "go help" list in alphabetical order

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/94017 mentions this issue: cmd/go: "go help" list put in alphabetical order

gopherbot pushed a commit that referenced this issue Feb 14, 2018
@nathanwilk7 @bradfitz
cmd/go: put "go help" list in the right order, take 2
9dba56b 
The previous fix had "bug" and "build" in the wrong order.

Fixes #23791

Change-Id: I4897428516b159966c13c1054574c4f6fbf0fbac
Reviewed-on: https://go-review.googlesource.com/94017
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
4 participants
@bradfitz @rsc @gopherbot @nathanwilk7