Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: add 421 status codes into status.go #23776

Closed
ryysud opened this issue Feb 11, 2018 · 7 comments
Closed

net/http: add 421 status codes into status.go #23776

ryysud opened this issue Feb 11, 2018 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.11

Comments

@ryysud
Copy link
Contributor

ryysud commented Feb 11, 2018

The following HTTP status codes are registered in the HTTP Status Code Registry, but they are not defined in the net/http package (status.go) .

Is there a reason not to define them?
@gopherbot
Copy link

Change https://golang.org/cl/93296 mentions this issue: net/http: add missing HTTP status codes

@odeke-em odeke-em changed the title net/http: There are missing HTTP status codes net/http: add 103 and 421 status codes into status.go Feb 11, 2018
@odeke-em
Copy link
Member

Hello there @ryysud, thank you for raising this issue and welcome to Go!

Interesting, TIL. So from what I can quickly examine:

screen shot 2018-02-11 at 1 58 20 am

  • 421 Misdirected request, perhaps that's a complex interaction with crypto/tls and x/net/http2 so I'll page the wizards @tombergan @bradfitz @agl @rs

@odeke-em odeke-em added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 11, 2018
@odeke-em odeke-em added this to the Go1.11 milestone Feb 11, 2018
@bradfitz
Copy link
Contributor

I'm fine adding 421. Let's wait on 103 until it's finalized.

@ryysud
Copy link
Contributor Author

ryysud commented Feb 11, 2018

@odeke-em
Thank you for your investigation.

@bradfitz
Thank you for the review.
Should I remove 103 from the CL?

@meirf
Copy link
Contributor

meirf commented Feb 11, 2018 •
edited

FWIW there is some discussion of 421 in #18341, including some comments authored by a definite muggle (me).

@bradfitz
Copy link
Contributor

Should I remove 103 from the CL?

Yes.

@ryysud
Copy link
Contributor Author

ryysud commented Feb 12, 2018

@bradfitz I removed 103 from the CL.

@ryysud ryysud changed the title net/http: add 103 and 421 status codes into status.go net/http: add 103 status codes into status.go Feb 12, 2018
@ryysud ryysud changed the title net/http: add 103 status codes into status.go net/http: add 421 status codes into status.go Feb 12, 2018
@golang golang locked and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
5 participants
@bradfitz @meirf @odeke-em @ryysud @gopherbot