New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text/scanner: add examples #23768
Comments
You don't have to do both. For example, if you find that the |
Is it most appropriate to post examples here for discussion before opening a CL? |
You should just open a CL. Generally we ask that people don’t send code reviews until it’s agreed upon that a proposal should be implemented (adding a new package, changing something non-trivial). For documentation changes like adding examples, it’s reasonable to simply send out the code review and have a discussion there. |
Change https://golang.org/cl/93199 mentions this issue: |
Is there anything I can do to facilitate a review of my CL? I'm new to the Golang CL process and don't know really what to expect. |
According to the owners file, Robert owns the |
I recently worked with the text/scanner package and, although the documentation was straight forward, it could stand to use more examples.
I've been looking for opportunities to contribute to Go and I wouldn't mind working on improving the examples of the text/scanner package. I would like to add examples detailing the use of white space modifiers and tokens, as well as the various scanner and position methods. I would keep each example succinct, of course.
Are there particular guidelines to follow when it comes to examples?
The text was updated successfully, but these errors were encountered: