Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: should application/x-javascript be changed to application/javascript ? #23767

Closed
romainmenke opened this issue Feb 10, 2018 · 3 comments
Closed

Comments

@romainmenke
Copy link

romainmenke commented Feb 10, 2018

".js": "application/x-javascript",

What did you do?

Serve javascript files with go. The application runs in a docker container based on golang:1-alpine

What did you expect to see?

Content-Type : application/javascript

What did you see instead?

Content-Type : application/x-javascript


Illustration did not fit in a playground : runnable example

relevant? rfc4329

As far as I can tell golang:1-alpine doesn't come with any registered mime types. This means that only the built in types are used for content type sniffing. application/javascript is not included in the built in types.

Should application/javascript be included and (separately) should application/x-javascript be removed?

@romainmenke romainmenke changed the title mime: should application/x-javascript be changed to application/javascript ? mime: should application/x-javascript be changed to application/javascript ? Feb 10, 2018
@ALTree
Copy link
Member

ALTree commented Feb 10, 2018

This is #7498, which is still open. There was a CL (https://codereview.appspot.com/73070043) but (from the old thread):

According to Brad's comment on the CL, we need more proof that change is safe in the wild.

and then the discussion stalled and the change was not merged.

@ALTree
Copy link
Member

ALTree commented Feb 10, 2018

I've moved the old thread into the 1.11 milestone and tentatively labelled as "NeedsDecision" to give it a chance to be looked at in the near future. I guess you can comment in the old thread if you have any insights on why this would be a needed (and safe) change, to keep all the discussion in one place. I suggest we close this as a dup of #7498.

@romainmenke
Copy link
Author

@ALTree Yes this can be closed as it is indeed a duplicate (search failed me, or overlooked it). Thank you for the fast response.

@golang golang locked and limited conversation to collaborators Feb 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants