Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: editing a title or description should update the Gerrit change #23756

Closed
andybons opened this issue Feb 9, 2018 · 3 comments
Closed

x/build/cmd/gerritbot: editing a title or description should update the Gerrit change #23756

andybons opened this issue Feb 9, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@andybons
Copy link
Member

andybons commented Feb 9, 2018

In this change the title needs to be adjusted, but it won't get imported unless the PR branch's HEAD SHA changes. We should detect differences in the title and import if need be.
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 9, 2018
@andybons andybons self-assigned this Feb 9, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 9, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 9, 2018
@dmitshur dmitshur mentioned this issue Feb 24, 2018
Closed
@dmitshur
Copy link
Contributor

This is also affecting PR golang/tools#26 (comment).

@gopherbot
Copy link

Change https://golang.org/cl/96995 mentions this issue: cmd/gerritbot: ensure commit message consistency

@gopherbot
Copy link

Change https://golang.org/cl/96999 mentions this issue: cmd/gerritbot: use full commit message to determine staleness

gopherbot pushed a commit to golang/build that referenced this issue Feb 26, 2018
@andybons
cmd/gerritbot: ensure commit message consistency
3203ec0 
The message generated by the commitMessage method
does not always match the one that Gerrit sees.
This is because the commit-msg hook runs git stripspace
and has different logic for placing the Change-Id.

Remove the commit-msg hook and insert a Change-Id
(a SHA-1 hash preceded with an I) using the Pull
Request’s ID and run git stripspace on the generated
commit message.

This is preparation for updating the Gerrit CL once
the title or description changes.

Also updates Dockerfile.0 to use 1.10 and disable
cgo so that building doesn’t emit errors.

Updates golang/go#23756

Change-Id: Ib437d3e9c1496ad1bee6268afcbe7c766eb82bde
Reviewed-on: https://go-review.googlesource.com/96995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot