Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/get: fix regexes for "any" character matching #23755

Closed
wants to merge 1 commit into from
Closed

cmd/go/internal/get: fix regexes for "any" character matching #23755

wants to merge 1 commit into from

Conversation

ofpiyush
Copy link
Contributor

@ofpiyush ofpiyush commented Feb 9, 2018

Minor bug: hubajazz.net and gitbapache.org would match, probably shouldn't

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 9, 2018
@gopherbot
Copy link

This PR (HEAD: 531de6d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/92997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Gobot Gobot has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Andrew Bonventre has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Brad Fitzpatrick has posted review comments at golang.org/cl/92997.

@ofpiyush ofpiyush changed the title cmd/go/internal/get: fix regexes for "any" character matching cmd/go/internal/get: fix regexes for "any" character matching Feb 9, 2018
@gopherbot
Copy link

This PR (HEAD: 75bd338) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/92997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Piyush Mishra has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Dmitri Shuralyov has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Dmitri Shuralyov has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Brad Fitzpatrick has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Andrew Bonventre has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Brad Fitzpatrick has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Andrew Bonventre has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Piyush Mishra has posted review comments at golang.org/cl/92997.

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

This would also need a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Piyush Mishra:

Patch Set 2:

Patch Set 1:

This would also need a test.

Added tests and also removed the leading space with a force push.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Piyush Mishra:

Patch Set 2:

(2 comments)

Patch Set 1:

This would also need a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to
publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

This would also need a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Piyush Mishra:

Patch Set 2:

Patch Set 1:

This would also need a test.

Added tests and also removed the leading space with a force push.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Piyush Mishra:

Patch Set 2:

(2 comments)

Patch Set 1:

This would also need a test.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@andybons
Copy link
Member

Apologies for the duplicate posts on this.

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bdb55692

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/92997.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 13, 2018
@ofpiyush @bradfitz
cmd/go/internal/get: fix regexes for "any" character matching
71984fd 
Minor bug: `hubajazz.net` and `gitbapache.org` would match, probably shouldn't

GitHub-Last-Rev: 75bd338
GitHub-Pull-Request: #23755
Change-Id: Ie9c9ab1c15364eccdab8cf3b106b9c370e7f532f
Reviewed-on: https://go-review.googlesource.com/92997
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/92997 has been merged.

@gopherbot gopherbot closed this Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ofpiyush @gopherbot @andybons @googlebot