Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc/dl: provide a JSON feed of Go releases #23746

Closed
zachgersh opened this issue Feb 8, 2018 · 17 comments
Closed

x/tools/godoc/dl: provide a JSON feed of Go releases #23746

zachgersh opened this issue Feb 8, 2018 · 17 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10

Comments

@zachgersh
Copy link

zachgersh commented Feb 8, 2018 •
edited

Currently there seems to be no programmatic way I can consume a list of releases / checksums when a new release is published (especially relevant for CVEs).

It would be great if there was a JSON feed (or some other mechanism) that would allow users to determine what the latest release download links / checksums were.

Unsure what sort of URL this would be presented of off but I could imagine something like GET https://golang.org/dl/releases.json
@gopherbot gopherbot added this to the Proposal milestone Feb 8, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Feb 8, 2018

I thought we had a bug about this, but maybe not. In any case, this came up somewhere and we agreed it as a good idea. It should be simple to add too, if you want to send a change to golang.org/x/tools/godoc/dl/dl.go

@bradfitz bradfitz changed the title Proposal: Provide a JSON feed for Golang Releases x/tools/godoc/dl: provide a JSON feed of Go releases Feb 8, 2018
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Feb 8, 2018
@bradfitz bradfitz modified the milestones: Proposal, Go1.11 Feb 8, 2018
@zachgersh
Copy link
Author

@bradfitz - sounds great, I'll get around to this during the weekend. Any thoughts on the releases.json URL? Could probably just be /releases

@bradfitz
Copy link
Contributor

bradfitz commented Feb 8, 2018

I don't care much. We use ?mode=json for https://build.golang.org/?mode=json though.

@zachgersh
Copy link
Author

PR here: golang/tools#21

@zachgersh zachgersh mentioned this issue Feb 21, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/93080 mentions this issue: godoc/dl: provide JSON feed of releases

@xdg
Copy link

xdg commented Feb 21, 2018

Is it correct that this (shortly)be available via https://golang.org/dl/?mode=json

@andybons
Copy link
Member

This requires a cherry-pick into the 1.10 branch of tools and a deploy. Will need an OK from @bradfitz first.

@bradfitz
Copy link
Contributor

I'm in no rush for it but if others need it for something and @andybons has time, I don't object.

@bradfitz bradfitz reopened this Feb 22, 2018
@bradfitz
Copy link
Contributor

I reverted the change. It doesn't compile. See https://go-review.googlesource.com/c/tools/+/93080

zachgersh pushed a commit to terrorform/tools that referenced this issue Feb 22, 2018
godoc/dl: provide JSON feed of releases
b82824a 
Fixes golang/go#23746
zachgersh pushed a commit to terrorform/tools that referenced this issue Feb 22, 2018
godoc/dl: provide JSON feed of releases
deda4f7 
Fixes golang/go#23746
@zachgersh zachgersh mentioned this issue Feb 22, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/96178 mentions this issue: godoc/dl: provide JSON feed of releases

alindeman pushed a commit to alindeman/tools that referenced this issue Feb 23, 2018
@alindeman
godoc/dl: provide JSON feed of releases
5109ec3 
Fixes golang/go#23746

GitHub-Last-Rev: a188d86
GitHub-Pull-Request: golang#21
Change-Id: I0ca504081b239cd3cd8f7c1aed205807b5279d2b
Reviewed-on: https://go-review.googlesource.com/93080
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons
Copy link
Member

Re-opening for 1.10.1

@andybons andybons reopened this Mar 27, 2018
@andybons andybons modified the milestones: Go1.11, Go1.10.1 Mar 27, 2018
@zachgersh
Copy link
Author

@andybons - assuming this is for the deployment of the app?

@andybons
Copy link
Member

@zachgersh yes.

@andybons andybons mentioned this issue Mar 27, 2018
Closed
@andybons
Copy link
Member

andybons commented Mar 27, 2018 •
edited

CL 102795 OK for Go 1.10.1

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed NeedsFix The path to resolution is known, but the work has not been done. Proposal Proposal-Accepted help wanted labels Mar 27, 2018
@zachgersh
Copy link
Author

cc @cppforlife

@gopherbot
Copy link

Change https://golang.org/cl/102795 mentions this issue: [release-branch.go1.10] godoc/dl: provide JSON feed of releases

@andybons
Copy link
Member

andybons commented Mar 27, 2018 •
edited

Closing since releasebot is unhappy with cherry-picks from the tools repo. This will be cherry-picked into the 1.10 release branch.

@andybons andybons modified the milestones: Go1.10.1, Go1.10 Mar 27, 2018
@andybons andybons reopened this Mar 27, 2018
@andybons andybons modified the milestones: Go1.10.1, Go1.10 Mar 27, 2018
gopherbot pushed a commit to golang/tools that referenced this issue Mar 28, 2018
@andybons
[release-branch.go1.10] godoc/dl: provide JSON feed of releases
bd7f39a 
This addresses the build errors that caused a
revert of the original PR #21

Fixes golang/go#23746

GitHub-Last-Rev: 6606c0b
GitHub-Pull-Request: #25
Change-Id: Ic5a7e3054d182dc2041d2966ca68960c3abd7620
Reviewed-on: https://go-review.googlesource.com/96178
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 86e0f67)
Reviewed-on: https://go-review.googlesource.com/102795
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@johnweldon johnweldon mentioned this issue Dec 21, 2018
Closed
@golang golang locked and limited conversation to collaborators Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
5 participants
@bradfitz @andybons @zachgersh @xdg @gopherbot