cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS #23739

susugagalala · 2018-02-08T06:58:43Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go 1.9.4

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (`go env`)?

macOS High Sierra 10.13.3 / amd64

What did you do?

go build programusingcgo.go

What did you expect to see?

successful building process (built fine with go 1.9.3 and earlier versions)

What did you see instead?

$go build programusingcgo.go
github.com/samplepkg: invalid flag in #cgo LDFLAGS: github.com/samplepkg/mylib_darwin_amd64.a
$

The text was updated successfully, but these errors were encountered:

dgryski · 2018-02-08T07:55:05Z

Is this a public repository? Can you give more details of the cgo usage? What does the cgo directive actually say?

raydac · 2018-02-08T07:55:41Z

I have the same issue with Go 1.9.4 in my test
go build github.com/andlabs/ui: invalid flag in #cgo LDFLAGS: /home2/igorm/.mvnGoLang/.go_path/src/github.com/andlabs/ui/libui_linux_amd64.a

rasky · 2018-02-08T08:36:43Z

@raydac andlabs/ui must be updated to cope with the new Go release. I've opened a bug (andlabs/ui#268).

@susugagalala we need to see the #cgo LDFLAGS line that is rejected by the compiler.

ruiadrmartins · 2018-02-08T11:04:00Z

same happened to me while trying to build miekg/pkcs11
go build github.com/miekg/pkcs11: invalid flag in #cgo LDFLAGS: -Wl,--no-as-needed

It was working fine yesterday. Reverting to go 1.9.3 solved it

dmitris · 2018-02-08T11:31:48Z

@ruiadrmartins - miekg/pkcs11#63

dmitris · 2018-02-08T11:32:55Z

workaround for github.com/miekg/pkcs11 on Linux - CGO_LDFLAGS_ALLOW='-Wl,--no-as-needed' go install (same for go test)

pebbe · 2018-02-08T12:07:33Z

I have the same issue with CFLAGS in Go version 1.9.4. It was working fine in version 1.9.3.

~ go get github.com/pebbe/tokenize
go build github.com/pebbe/tokenize: invalid flag in #cgo CFLAGS: -finput-charset=UTF-8

 ~ go version
go version go1.9.4 linux/amd64

~ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/peter/go"
GORACE=""
GOROOT="/my/opt/go"
GOTOOLDIR="/my/opt/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build312239203=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

ruiadrmartins · 2018-02-08T12:13:19Z

The problem has to do with this: #23672
It affects Go versions 1.8.7, 1.9.4 and 1.10rc2
Reverting to the previous version is what I'm doing now. Waiting for a better solution.

andlabs · 2018-02-08T12:26:12Z

Is allowing linking to files in ${SRCDIR} out of the question? Package ui needs to link to a .res file on Windows as well (because resources + static libraries are weird; I should probably just remove the resources entirely, but that'll be a big change).

Is the pkcs11 flag (-Wl,--no-as-needed) also out of the question?

Honestly, I'd argue that packages that break with the security fix should first see if their flag can safely be whitelisted before taking action, because gcc and clang have so many disparate linker flags that package authors must assume that all of them affect compilation in a significant way. (This is a problem I have with many C build tools that try to hide those details from the programmer; I want to know exactly what my build is doing and what edge cases I would otherwise miss because of them.)

susugagalala · 2018-02-08T12:36:10Z

@dgryski @rasky That was just an example. It's not an actual repository. I have too many cgo calls in my projects, all resulting in the same error messages, so I did not provide the actual code... just a sample example...
Apparently, from go 1.9.4, one cannot pass arbitrary "flags" to the linker via LDFLAGS, etc. I'm surprised, however, arbitrary "flags" can still be passed to the compiler via CFLAGS, etc.
After reading through https://golang.org/cmd/cgo/, I realised from 1.9.4, only a limited set of flags are allowed and proper regular expressions must be used. I've modified all my projects and they all now build successfully.

pebbe · 2018-02-08T12:42:59Z

Why is this issue closed? It's not solved.

dmitris · 2018-02-08T12:44:47Z

There is a patch for Go proposed - #23743

andlabs · 2018-02-08T14:36:32Z

@susugagalala again, I suggest asking if the flags that caused your projects issues could be whitelisted. Can you tell us what they are?

(I'm genuinely concerned that people are treating these breakages as issues with Go itself, or even with the packages themselves, rather than seeing the security issue that caused it. I'm even more concerned that the solution is to just discard compiler flags with reckless abandon; compiler flags are always there for a reason, and we should exhaust all avenues before making a change to them.)

ianlancetaylor · 2018-02-08T18:00:51Z

I've created an issue to collect all options that should be added to the whitelists: #23749. Please add comments there as needed; I believe that all the options mentioned in this issue are already there.

stevenzack · 2018-02-14T09:43:22Z

same problem happened when I try to build go-sciter, it works fine on Go1.9.3.

andlabs · 2018-02-14T11:38:23Z

@stevenzack please go to #23749 to report that issue then; that's where all these are being collected.

GB seems semi-abandoned, and currently doesn't cross compile with either go-1.9.4 or go-1.10 ([bug][1]). Possibly due to the new cgo flag whitelisting (see: [go issue: 23739][2])? Instead: * require devs to put into GOPATH, as this seems unfortunately to be the convention the go community arrived at :( * use dep for vendoring * use gox for easy cross compilation [1]: constabulary/gb#733 [2]: golang/go#23739

UI lib doesn't support golang >= 1.9.3 More info golang/go#23739

rasky added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 8, 2018

susugagalala closed this as completed Feb 8, 2018

ianlancetaylor mentioned this issue Feb 8, 2018

cmd/go: options missing from cgo whitelists #23749

Closed

dannypsnl mentioned this issue Feb 12, 2018

[Bug]LLVM can't compile now dannypsnl/elz#32

Closed

justinfx mentioned this issue Feb 14, 2018

go build gopkg.in/gographics/imagick.v3/imagick: invalid flag in pkg-config --cflags: -fopenmp gographics/imagick#155

Closed

mikioh changed the title ~~go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS~~ cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS Feb 21, 2018

evilsocket mentioned this issue Feb 28, 2018

invalid flag in #cgo LDFLAGS (bug in some Go versions while compiling statically) bettercap/bettercap#101

Closed

2 tasks

metacoma pushed a commit to metacoma/silverkey that referenced this issue Mar 31, 2018

Downgrade golang to 1.9.3

c0a4692

UI lib doesn't support golang >= 1.9.3 More info golang/go#23739

golang locked and limited conversation to collaborators Feb 21, 2019

gopherbot added the FrozenDueToAge label Feb 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS #23739

cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS #23739

susugagalala commented Feb 8, 2018

dgryski commented Feb 8, 2018

raydac commented Feb 8, 2018

rasky commented Feb 8, 2018

ruiadrmartins commented Feb 8, 2018

dmitris commented Feb 8, 2018

dmitris commented Feb 8, 2018 •

edited

pebbe commented Feb 8, 2018

ruiadrmartins commented Feb 8, 2018

andlabs commented Feb 8, 2018 •

edited

susugagalala commented Feb 8, 2018

pebbe commented Feb 8, 2018

dmitris commented Feb 8, 2018 •

edited

andlabs commented Feb 8, 2018 •

edited

ianlancetaylor commented Feb 8, 2018

stevenzack commented Feb 14, 2018

andlabs commented Feb 14, 2018

cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS #23739

cmd/cgo: go 1.9.4 cgo issue: invalid flag in #cgo LDFLAGS #23739

Comments

susugagalala commented Feb 8, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

dgryski commented Feb 8, 2018

raydac commented Feb 8, 2018

rasky commented Feb 8, 2018

ruiadrmartins commented Feb 8, 2018

dmitris commented Feb 8, 2018

dmitris commented Feb 8, 2018 • edited

pebbe commented Feb 8, 2018

ruiadrmartins commented Feb 8, 2018

andlabs commented Feb 8, 2018 • edited

susugagalala commented Feb 8, 2018

pebbe commented Feb 8, 2018

dmitris commented Feb 8, 2018 • edited

andlabs commented Feb 8, 2018 • edited

ianlancetaylor commented Feb 8, 2018

stevenzack commented Feb 14, 2018

andlabs commented Feb 14, 2018

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

dmitris commented Feb 8, 2018 •

edited

andlabs commented Feb 8, 2018 •

edited

dmitris commented Feb 8, 2018 •

edited

andlabs commented Feb 8, 2018 •

edited