Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/bundle: binary name conflicts with ruby bundle #23700

Closed
jordimassaguerpla opened this issue Feb 5, 2018 · 4 comments
Closed

x/tools/cmd/bundle: binary name conflicts with ruby bundle #23700

jordimassaguerpla opened this issue Feb 5, 2018 · 4 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@jordimassaguerpla
Copy link

Installing the x/tools package will install a binary called bundle, which conflicts which the bundle binary installed by the bundler ruby gem.

Could it be possible to rename bundle to go-bundle or something that will not clash?

Thanks

@ALTree ALTree changed the title bundle (from the x/tools subpackage) conflicts with ruby bundle x/tools/cmd/bundle: binary name conflicts with ruby bundle Feb 5, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 5, 2018
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 5, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Feb 5, 2018

x/tools/cmd/bundle has approximately 1 user in the world, and that's an internal use by the Go project itself. And we don't use Ruby, so it's not a conflict. If it's a conflict for you, don't install it, or put them in different paths.

@bradfitz bradfitz closed this as completed Feb 5, 2018
@jordimassaguerpla
Copy link
Author

jfyi this is a "conflict" that arise while packaging x/tools in the openSUSE community

https://build.opensuse.org/request/show/573082

Go and Ruby coexist in a distribution and it is fair for users to expect that they could install both, and I am not only referring to go and ruby themselves, but also to the subpackages/modules/gems/. Thus, I would expect to be able to to install go x/tools and rubygem bundler.

However, if only 1 user in the world uses x/tools/cmd/bundle, I guess we could just rename it in our package to something like go-bundle.

@bradfitz
Copy link
Contributor

bradfitz commented Feb 5, 2018

Making the disto package per Go repo is a debatable choice by itself. But assuming you proceed (or continue) with that, I'd just not package x/tools/cmd/bundle. In fact, I'd move from a blacklist to a whitelist of what you package. You should define your "tools" distro package as a certain set of actually useful tools that users want. godoc, eg, gorename, etc.

@baiyunping333
Copy link

hi,you can use full path, like

// Code generated by golang.org/x/tools/cmd/bundle. DO NOT EDIT.
//go:generate ~/gopath/bin/bundle -o x_net_proxy.go golang.org/x/net/proxy
// Package proxy provides support for a variety of protocols to proxy network
// data.
//

@golang golang locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

5 participants