Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: fix code.google.com links #23688

Closed
as opened this issue Feb 4, 2018 · 6 comments
Closed

blog: fix code.google.com links #23688

as opened this issue Feb 4, 2018 · 6 comments
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@as
Copy link
Contributor

as commented Feb 4, 2018 •
edited

Source: https://blog.golang.org/introducing-gofix

Summary: The links in the article above (paragraph 4) redirect the user to the Go github repository landing page.
See also: #8692
@bradfitz bradfitz changed the title blog: gofix example file links redirect to github.com/golang/go blog: fix code.google.com links Feb 4, 2018
@bradfitz bradfitz added this to the Unreleased milestone Feb 4, 2018
@bradfitz bradfitz added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Feb 4, 2018
@gideondsouza
Copy link

is the blog part of this repo? are you accepting pr's ?

@bradfitz
Copy link
Contributor

bradfitz commented Feb 4, 2018

Yes: https://github.com/golang/blog/

We don't accept PRs via GitHub ... yet. Soon. Currently you need to use Gerrit, but wait maybe a week and we should accept PRs.

@ysmolski
Copy link
Member

ysmolski commented Feb 14, 2018 •
edited

@bradfitz, those links in the article point to sources which were deleted in this commit:

   cmd/fix: delete pre-Go 1 fixes
    
    Assume people who were going to update to Go 1 have done so.
    Those with pre-Go 1 trees remaining will need to update first
    to Go 1.0 (using its 'go fix') and then to Go 1.1.

Does it makes sense to point to different but actual examples in the repo?

@bradfitz
Copy link
Contributor

Why don't you just change the links to point to source browser URLs linking into old branches?

@gopherbot
Copy link

Change https://golang.org/cl/94235 mentions this issue: blog: fix code.google.com links

@ysmolski
Copy link
Member

Alright, done. I have fixed all other broken links I could find.

@golang golang locked and limited conversation to collaborators Feb 15, 2019
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@ysmolski @bradfitz
[x/blog] blog: fix code.google.com links
b0bd610 
Deprecated links to code.google.com were replaced with relevant links.

Fixes golang/go#23688

Change-Id: I6f97ce072258a3a319df22d1df5773726ad5b801
Reviewed-on: https://go-review.googlesource.com/94235
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
X-Blog-Commit: b75d504c8a09e20834f367977a6dc71353d8131a
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] blog: fix code.google.com links
f3f7aff 
Deprecated links to code.google.com were replaced with relevant links.

Fixes golang/go#23688

Change-Id: I6f97ce072258a3a319df22d1df5773726ad5b801
Reviewed-on: https://go-review.googlesource.com/94235
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
X-Blog-Commit: b75d504c8a09e20834f367977a6dc71353d8131a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @ysmolski @gideondsouza @as @gopherbot