Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text/scanner: Allow users of ScanRawStrings to get a RawString #23675

Closed
metaleap opened this issue Feb 2, 2018 · 2 comments
Closed

text/scanner: Allow users of ScanRawStrings to get a RawString #23675

metaleap opened this issue Feb 2, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@metaleap
Copy link

metaleap commented Feb 2, 2018 •
edited

Currently, even with ScanRawStrings enabled, all "raw" (delimited by backticks) strings will trigger String tokens rather than RawString tokens. From a text/scanner-only perspective, this could be fixed by changing L624 in scanner.go as outlined in this patch:

go-forks@d869c9a

Regrettably I don't have the time for the endless litany of steps outlined in https://golang.org/doc/contribute.html just to submit such a brazenly trivial PR, so whoever contributor wants to pick this up, please be my guest =)
@ianlancetaylor
Copy link
Contributor

We now accept GitHub pull requests. Want to send in your patch?

@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 28, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 28, 2018
@SilverRainZ SilverRainZ mentioned this issue May 8, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/112037 mentions this issue: text/scanner: return RawString token rather than String for raw string literals

patrobinson pushed a commit to patrobinson/ddb that referenced this issue Jan 15, 2019
Remove support for prior golang versions
58973a2 
We can't use backticks until 1.11 because of this issue golang/go#23675
@golang golang locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@metaleap @ianlancetaylor @gopherbot