-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/devapp: support R= annotations in commit messages #23656
Comments
Also, I want this (and others like DNR, etc) is documented in the contribution guideline. |
Used R= in the commit message based on other CLs i had seen. e.g. My intention is to remove them from my commit messages once the tree is open and before commit but I too see the problem that it is easy to forget. |
I suppose we could also make the bot mark them as Do-Not-Submit (or just -2 them) until the R=go1.N tree is open too. |
I do. For those who are heavy A similar question exists for Does gerrit support pre-submit hooks? We could have gerrit rewrite away such lines in the commit message. Then out bot would just need to replicate the commit message annotations in gerrit comments. |
Same for me. Also, my idea was to save reviewer's time (even though https://golang.org/cl/91055 was then approved for go1.10) and for myself to keep track of my branches/CLs locally. Also being a |
I actually propose we stop using magic comments and start using CL-level tags in Gerrit. Gerrit calls the feature "hashtags", and it's now supported by the PolyGerrit UI. We're using them in Perkeep and they're great. It means we can search on them, too. On their silly name: https://groups.google.com/forum/#!topic/repo-discuss/jZ0raMyuiG0 https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-hashtags Example Gerrit search: https://camlistore-review.googlesource.com/q/is:open+-owner:mathieu+-hashtag:op (we use the "op" tag in Perkeep to mean that it's the CL author's turn to do something). /cc @andybons |
This can also be achieved by setting the “assignee” field, right? |
Maybe. It was just an example. |
The Gerrit hashtag |
I see people using R= in commit messages, instead of in comments:
https://go-review.googlesource.com/c/go/+/91435
https://go-review.googlesource.com/c/go/+/63274
Do we want to support R= in commit messages too?
Easy technical change. But do we care about commit message prettiness? One CL was R=go1.11 and we approved it for Go 1.10. Fortunately @tklauser updated the commit message before submitting, but that won't always be the case if we make our tooling support R=go1.N and promote its use.
/cc @andybons @ianlancetaylor
The text was updated successfully, but these errors were encountered: