-
Notifications
You must be signed in to change notification settings - Fork 18k
database/sql: add String method to IsolationLevel #23632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
I could implement it if you are ok with it. |
AlekSi
added a commit
to AlekSi/mysql
that referenced
this issue
Jan 31, 2018
It was "mysql: unsupported isolation level: \a" due to wrong conversion from int to string. See also golang/go#23632
5 tasks
If you're going to use |
/cc @bradfitz @kardianos |
There aren't that many levels. It's OK to write a String method by hand. But sure, adding a String method is fine. |
Change https://golang.org/cl/92235 mentions this issue: |
AlekSi
added a commit
to AlekSi/go
that referenced
this issue
Feb 20, 2018
Fixes golang#23632 Change-Id: I7197e13df6cf28400a6dd86c110f41129550abb6
julienschmidt
pushed a commit
to go-sql-driver/mysql
that referenced
this issue
Mar 3, 2018
* Fix error message for unsupported isolation level. It was "mysql: unsupported isolation level: \a" due to wrong conversion from int to string. See also golang/go#23632 * Add myself and sort authors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be useful in code like this:
Without it, all driver authors have to implement the mapping in the driver itself, or not bother with helpful error messages. Examples:
string([int])
does not work as author probably thought it doesThe text was updated successfully, but these errors were encountered: