Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: collapsing overview does not hide example #23590

Closed
agnivade opened this issue Jan 28, 2018 · 1 comment
Closed

x/tools/godoc: collapsing overview does not hide example #23590

agnivade opened this issue Jan 28, 2018 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.11

Comments

@agnivade
Copy link
Contributor

What did you do?

Collapse the Overview container found on any package page.

Examples -
heap

What did you expect to see?

The entire bar should be closed hiding the example.

What did you see instead?

The example was not hidden.

heap-closed

This is due to a minor bug where {{example_html $ ""}} is outside the #pkg-overview.expanded div. Moving it inside the div fixes it. I will send a CL for this.
@gopherbot gopherbot added this to the Unreleased milestone Jan 28, 2018
@gopherbot
Copy link

Change https://golang.org/cl/90396 mentions this issue: godoc: move package example section

@andybons andybons modified the milestones: Unreleased, Go1.11 Jan 29, 2018
@andybons andybons self-assigned this Jan 29, 2018
@golang golang locked and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@andybons @agnivade @gopherbot