New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/godoc: Go source files format misses one tabulation on firefox #23500
Comments
I see it with the same Firefox on macOS 10.12.6. Chrome here also appears ok. Adding a From https://developer.mozilla.org/en-US/docs/Web/CSS/white-space:
This looks like a Firefox problem. I'm not seeing anything for this here: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=white-space. If nothing different is found and somebody with a Bugzilla account doesn't do it first I'll open up a bug there this week. |
This seems to be a macOS+FF problem. In my ubuntu 16.04+FF 57.0.4, it works fine. Update - Tested with Windows 10 + FF 57.0.4. Works fine there too. |
Works fine here: OpenSuse Leap 42.3 + FF 52.5.3 (64-bit). |
@agnivade which FF? |
@pciet - updated my comment. |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
@gopherbot the bugzilla issue has been put into a component and set to priority 3 but no other progress has been made. There's a smaller example linked there that shows the problem. |
hmm, gopherbot doesn't seem happy with me trying to reopen this. I want to take a crack at this, it's pretty annoying and I probably wrote the tab-indenting code in the first place so a fix is on me. |
So this is weird: https://jsbin.com/cavayixako/edit?html,output I can only reproduce it with Menlo, another font does not show the same issue. With the Menlo font in Firefox, a tab character starting in column 9 has zero width. I can't reproduce that JSBin in Chrome. It's a hack but you can work around it by adding another |
Change https://golang.org/cl/131716 mentions this issue: |
Does this issue reproduce with the latest release?
Yes
What did you do?
Visit https://golang.org/src/errors/errors.go with Firefox.
macOS 10.13.2
Chrome 63.0.3239.132
Firefox 57.0.4
What did you expect to see?
What can be seen with Chrome, see screenshot.
What did you see instead?
The Go source files format misses one tabulation, see screenshot.
The text was updated successfully, but these errors were encountered: