Go 1.9.3 release status

PROBLEMS WITH RELEASE

• CL 81055: bad Gerrit status: NEW (not MERGED)

Issues with fixes

• runtime: memory corruption crashes with os/exec on Linux kernel 4.4 #20427 runtime: memory corruption crashes with os/exec on Linux kernel 4.4
  • CL 76990 per andybons; runtime: call amd64 VDSO entry points on large stack
• cmd/compile: "offset too large" error #21655 cmd/compile: "offset too large" error
  • CL 82675 per andybons; cmd/compile: fix large load/store offsets on 386
• cmd/compile: invalid instruction error for FMOVD when compiling for 387 #22429 cmd/compile: invalid instruction error for FMOVD when compiling for 387
  • CL 73551 per andybons; cmd/compile: make sure not to use SP as an index register
• cmd/compile: runtime.KeepAlive doesn't work #22458 cmd/compile: runtime.KeepAlive doesn't work
  • CL 74210 per andybons; cmd/compile: fix runtime.KeepAlive
• cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop #22683 cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop
  • CL 71731 per andybons; cmd/compile: provide more names for stack slots
  • CL 77332 per andybons; cmd/compile: add test for array decomposition
• runtime: reported CPU time of STW phases is low #22725 runtime: reported CPU time of STW phases is low
  • CL 77710 per andybons; runtime: fix gctrace STW CPU time and CPU fraction
• runtime: fatal error: sweep increased allocation count, go1.9.x #22781 runtime: fatal error: sweep increased allocation count, go1.9.x
  • CL 79018 per andybons; cmd/compile: fix mapassign_fast* routines for pointer keys
• math/big: r.Exp(x, 1, m) wrong if r is initially non-zero [Go1.9] #22842 math/big: r.Exp(x, 1, m) wrong if r is initially non-zero [Go1.9]
  • CL 81055 per andybons; math/big: clean up z.div(z, x, y) calls
• runtime: crash with C sigaltstacks #22930 runtime: crash with C sigaltstacks
  • CL 81476 per andybons; runtime: restore the Go-allocated signal stack in unminit
  • CL 81615 per andybons; runtime: use MAP_ANON in sigstack check
• database/sql: transaction leak #22976 database/sql: transaction leak
  • CL 81736 per andybons; database/sql: fix transaction leak
• net/http: backport invalid memory address or nil pointer dereference fix? #23066 net/http: backport invalid memory address or nil pointer dereference fix?
  • CL 72551 per andybons; http2: Discard data reads on HEAD requests
  • CL 75210 per andybons; net/http: update bundled http2
• net/url: Parse accepts invalid userinfo strings #23392 net/url: Parse accepts invalid userinfo strings
  • CL 87038 per andybons; net/url: reject invalid userinfo values when parsing URLs

Changes on release branch

• CL missing for cherry-pick of CL 71731 (for cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop #22683)
  • cmd/compile: provide more names for stack slots
• CL missing for cherry-pick of CL 72551 (for net/http: backport invalid memory address or nil pointer dereference fix? #23066)
  • http2: Discard data reads on HEAD requests
• CL missing for cherry-pick of CL 73551 (for cmd/compile: invalid instruction error for FMOVD when compiling for 387 #22429)
  • cmd/compile: make sure not to use SP as an index register
• CL missing for cherry-pick of CL 74210 (for cmd/compile: runtime.KeepAlive doesn't work #22458)
  • cmd/compile: fix runtime.KeepAlive
• CL missing for cherry-pick of CL 75210 (for net/http: backport invalid memory address or nil pointer dereference fix? #23066)
  • net/http: update bundled http2
• CL missing for cherry-pick of CL 76990 (for runtime: memory corruption crashes with os/exec on Linux kernel 4.4 #20427)
  • runtime: call amd64 VDSO entry points on large stack
• CL missing for cherry-pick of CL 77332 (for cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop #22683)
  • cmd/compile: add test for array decomposition
• CL missing for cherry-pick of CL 77710 (for runtime: reported CPU time of STW phases is low #22725)
  • runtime: fix gctrace STW CPU time and CPU fraction
• CL missing for cherry-pick of CL 79018 (for runtime: fatal error: sweep increased allocation count, go1.9.x #22781)
  • cmd/compile: fix mapassign_fast* routines for pointer keys
• CL missing for cherry-pick of CL 81055 (for math/big: r.Exp(x, 1, m) wrong if r is initially non-zero [Go1.9] #22842)
  • math/big: clean up z.div(z, x, y) calls
  • ERROR: bad Gerrit status: NEW (not MERGED)
• CL missing for cherry-pick of CL 81476 (for runtime: crash with C sigaltstacks #22930)
  • runtime: restore the Go-allocated signal stack in unminit
• CL missing for cherry-pick of CL 81615 (for runtime: crash with C sigaltstacks #22930)
  • runtime: use MAP_ANON in sigstack check
• CL missing for cherry-pick of CL 81736 (for database/sql: transaction leak #22976)
  • database/sql: fix transaction leak
• CL missing for cherry-pick of CL 82675 (for cmd/compile: "offset too large" error #21655)
  • cmd/compile: fix large load/store offsets on 386
• CL missing for cherry-pick of CL 87038 (for net/url: Parse accepts invalid userinfo strings #23392)
  • net/url: reject invalid userinfo values when parsing URLs

Log

2018/01/18 14:57:45 starting
2018/01/18 14:57:45 working in /usr/local/google/home/andybons/go-releasebot-work/go1.9.3
2018/01/18 14:57:45 $ git fetch origin master
2018/01/18 14:57:47 $ git fetch origin release-branch.go1.9
2018/01/18 14:57:47 $ git clone --reference /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitmirror -b release-branch.go1.9 https://go.googlesource.com/go /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitwork
2018/01/18 14:57:51 $ git codereview change relwork
2018/01/18 14:57:52 $ git config gc.auto 0
2018/01/18 14:57:52 $ git rev-parse go1.9.3
2018/01/18 14:57:54 $ git fetch origin master:gerrit/master release-branch.go1.9:gerrit/release-branch.go1.9 refs/changes/31/71731/13:gerrit/refs/changes/31/71731/13 refs/changes/51/72551/3:gerrit/refs/changes/51/72551/3 refs/changes/51/73551/3:gerrit/refs/changes/51/73551/3 refs/changes/10/74210/4:gerrit/refs/changes/10/74210/4 refs/changes/10/75210/2:gerrit/refs/changes/10/75210/2 refs/changes/90/76990/6:gerrit/refs/changes/90/76990/6 refs/changes/32/77332/2:gerrit/refs/changes/32/77332/2 refs/changes/10/77710/2:gerrit/refs/changes/10/77710/2 refs/changes/18/79018/3:gerrit/refs/changes/18/79018/3 refs/changes/55/81055/1:gerrit/refs/changes/55/81055/1 refs/changes/76/81476/6:gerrit/refs/changes/76/81476/6 refs/changes/15/81615/2:gerrit/refs/changes/15/81615/2 refs/changes/36/81736/3:gerrit/refs/changes/36/81736/3 refs/changes/75/82675/4:gerrit/refs/changes/75/82675/4 refs/changes/38/87038/2:gerrit/refs/changes/38/87038/2
2018/01/18 14:57:54 command failed: exit status 128
fatal: Couldn't find remote ref refs/changes/51/72551/3
2018/01/18 14:57:54 

PANIC: cmd

goroutine 83 [running]:
runtime/debug.Stack(0xc420f799d8, 0xa679e0, 0xbdc690)
	/usr/lib/google-golang/src/runtime/debug/stack.go:24 +0xa7
main.(*Work).recover(0xc420d38360)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:219 +0x71
panic(0xa679e0, 0xbdc690)
	/usr/lib/google-golang/src/runtime/panic.go:491 +0x283
main.(*Work).runOut(0xc420d38360, 0xc421210780, 0x14, 0x18, 0x8, 0xc420a1f380, 0x17)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:250 +0x3d7
main.(*Work).gitFetchCLs(0xc420d38360)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/git.go:136 +0x337
main.(*Work).doRelease(0xc420d38360)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:316 +0x6c6
main.main.func1(0xc420e3db70, 0xc420d38360)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:112 +0x51
created by main.main
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:110 +0x4e0

— golang.org/x/build/cmd/releasebot, Jan 18 19:57:54 UTC