New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys: extract Unix includes into separate files #23412
Comments
Was this proposed change discussed anywhere? Is there a reference issue? Or you are proposing the change now, here, and it needs discussion? |
There is no other ticket or discussion associated with the PR changeset. |
Sorry, we can't look at patches that are sent as PRs, without CLAs on file. Gerrit enforces CLAs. Please describe the problem in English and we can decide whether somebody can fix the problem independently. Or submit it via Gerrit. Or wait for us to start accepting GitHub PRs, soonish. (with the Google CLA bot) |
@bradfitz I have signed the CLA a while ago (via the Google CLA bot) and Gerrit lists it under "Agreements". |
@Androbin What is the problem? Please tell us the problem first, then the solution. Thanks. |
The script
I have extracted the former into separate files. @ianlancetaylor I have described this in the firstmost comment of the PR. |
I don't quite see a problem with that. FWIW I find it convenient to have the C code inlined in mkerrors.sh as the changes usually consist of adding a header and adjusting the regex in the same file. Splitting them out would mean having to remember to edit one (or even several) more files for each added/changed constant. |
This doesn't seem to be solving a real problem. Why do you want to do this? |
As I said, I thought it would be more convenient to have them separated. |
I have already submitted a PR for this on the GitHub mirror:
golang/sys#6
Unfortunately, I was unable to re-submit it via Gerrit.
Maybe someone else bothers to make the changes?
The text was updated successfully, but these errors were encountered: