New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html: move to exp/html #2341
Labels
Milestone
Comments
Issue #2229 has been merged into this issue. |
Issue #1889 has been merged into this issue. |
Issue #1751 has been merged into this issue. |
Issue #1661 has been merged into this issue. |
Owner changed to builder@golang.org. |
It's time to stop working on new code. Is package html done? If so, great. If not, let's move to exp/html and maybe it can be in Go 1.1. Thanks. Owner changed to @nigeltao. |
It's not done, in that it's not fully conformant with HTML5. But I don't expect any API changes between now and getting 100% of the test cases passing. It already handles trickiness like <svg> and <math>. But there might be some dark corner of HTML5 which isn't explored yet. I guess that that means that package html should move to exp/html. Is html/template unaffected? It currently depends on exp/html for a small utility function (html.UnescapeString), but that's copy/pastable. |
I've got second thoughts on copy/paste. There's non-trivial code [0] and a large look-up table [1]. [0] http://golang.org/src/pkg/html/escape.go?h=func+unescapeEntity#L57 [1] http://golang.org/src/pkg/html/entity.go?h=var+entity#L16 How about keeping html.EscapeString and htmlUnescapeString, but moving all the tokenization and parsing code to exp/html? The other option is moving html/template to exp/html/template. |
This issue was closed by revision 324513b. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: